[#11785] - [Force HTTPS] Allow also 401 code because of http authentication
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11785
- Diff
- andrepereiradasilva:patch-21
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11735.
Summary of Changes
Allow to save "Force HTTPS" "Administrator Only" or "Entire Site" if server behind Basic HTTP Authentication.
Testing Instructions
- Put the website behind Basic HTTP Authentication.
- Go to global config and change try to "Force HTTPS" "Administrator Only" or "Entire Site", try to save.
- Result: Warning not possible
- Apply patch
- Try again, now you can save with no issues.
Documentation Changes Required
None.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11785.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11785.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Title |
|
||||||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 20:00:28 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Hi & thank you for this Pull Request.
I only discover it right now, after the release of J!3.6.3 :-)
Actually, on all my websites running on (shared hosting) at SiteGround, enabling HTTPS from Global Configuration of Joomla does work fine.
But trying to enable it for all my (shared hosting) at OVH gives the following Warning :
HTTPS has not been enabled as it is not available on this server.
So I tested those sites after upgrading to J!3.6.3... but the Warning is still there, so still I can't force HTTPS from Global Configuration...
An example of such a site :
https://www.asolar-communication.be/fr
NB : I am no expert in https as such. But as you may know :
- LetsEncrypt is installed by default at OVH (the owner has nothging to do : they have done it theoretically for all the sites they host)
- while LetsEncrypt's installation must be launched by the owner from the cPanel at SiteGround
@woluweb if there's an issue with 3.6.3, the right place to open it is https://github.com/joomla/joomla-cms/issues
Thanks
this seems a server config related issue and not related to this PR.
as title says this PR only Allow also 401 code because of http authentication
Thank you for your kind answers.
My apologies, I had not understood what 401 was :-)
I'll post a new issue as you suggest.
Thank you Marc!
This code adjustement works for me. :-)