? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
25 Aug 2016

Pull Request for Issue #11765 .

Summary of Changes

Strangely the issue appears to be related to the 'user' field (Publishing tab), specifically a hidden cancel button which is rendered from an override in the Isis template. Removing the 'cancel' text resolves the issue however this points to the correct solution been elsewhere. Anyone more familiar with the Isis template I suspect would have a better solution?

Testing Instructions

  1. Create a new article
  2. Add an article title
  3. Click the alias field (or any text field), add text (or not).
  4. Hit 'enter' key

Before patch
Article is cancelled, navigating back to article manager.

After patch
Nothing

avatar ciar4n ciar4n - open - 25 Aug 2016
avatar ciar4n ciar4n - change - 25 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Category Templates (admin) Administration
avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Added: ?
avatar ciar4n ciar4n - change - 25 Aug 2016
The description was changed
avatar ciar4n ciar4n - edited - 25 Aug 2016
avatar ciar4n ciar4n - edited - 25 Aug 2016
avatar brianteeman
brianteeman - comment - 25 Aug 2016

@dgt41 could you take a look at this please

avatar brianteeman brianteeman - test_item - 25 Aug 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 25 Aug 2016

I have tested this item 🔴 unsuccessfully on 243f84b

I applied the patch but I dont see any changed behaviour


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.

avatar C-Lodder
C-Lodder - comment - 25 Aug 2016

This PR doesn't do what is intended at all. All you've done is removed the text (Cancel) from the modal footer button, resulting in an empty button, as shown below:

screeny

avatar C-Lodder
C-Lodder - comment - 25 Aug 2016

If you want to prevent the enter button from triggering the redirect, then you're going to have to go with a Javascript approach. Bare in mind that this occurs on most other components, not just com_content

avatar dgt41
dgt41 - comment - 25 Aug 2016

@brianteeman @C-Lodder a simple exchange of the <button> to a <a> solves this problem. @ciar4n can you make this change?

avatar dgt41
dgt41 - comment - 25 Aug 2016
avatar brianteeman
brianteeman - comment - 25 Aug 2016

I am closing in favour of 11787


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.

avatar brianteeman brianteeman - change - 25 Aug 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-08-25 11:29:08
Closed_By brianteeman
avatar brianteeman brianteeman - close - 25 Aug 2016

Add a Comment

Login with GitHub to post a comment