[#11782] - Fix for 'enter' keystroke cancelling article
- Closed
- 25 Aug 2016
- Medium
- Build: staging
- # 11782
- Diff
- ciar4n:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11765 .
Summary of Changes
Strangely the issue appears to be related to the 'user' field (Publishing tab), specifically a hidden cancel button which is rendered from an override in the Isis template. Removing the 'cancel' text resolves the issue however this points to the correct solution been elsewhere. Anyone more familiar with the Isis template I suspect would have a better solution?
Testing Instructions
- Create a new article
- Add an article title
- Click the alias field (or any text field), add text (or not).
- Hit 'enter' key
Before patch
Article is cancelled, navigating back to article manager.
After patch
Nothing
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Templates (admin) Administration |
| Labels |
Added:
?
|
||
I have tested this item
I applied the patch but I dont see any changed behaviour
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.
This PR doesn't do what is intended at all. All you've done is removed the text (Cancel) from the modal footer button, resulting in an empty button, as shown below:
If you want to prevent the enter button from triggering the redirect, then you're going to have to go with a Javascript approach. Bare in mind that this occurs on most other components, not just com_content
@brianteeman @C-Lodder a simple exchange of the <button> to a <a> solves this problem. @ciar4n can you make this change?
@brianteeman @C-Lodder @ciar4n check #11787
I am closing in favour of 11787
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 11:29:08 |
| Closed_By | ⇒ | brianteeman |
@dgt41 could you take a look at this please