[#11769] - Regression: Normalising head links and correcting hreflang for menu items associations
- Fixed in Code Base
- 26 Aug 2016
- Medium
- Build: staging
- # 11769
- Diff
- infograf768:head_links_normalise
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11759
Summary of Changes
Adding urldecode for the $base as as for the languagefilter component associations
EDIT: took off that in final PR
Testing Instructions
Enable unicode alias in global configuration.
Multilingual site.
Enable Item associations on the language filter plugin as well as Alternate meta tags
Associate items. One of the items should have some utf8 glyph in its alias.
Display the items one after the other, each time looking source for the hreflang produced (and the <base link when the item with utf8 alias is displayed)
The results are different: one hreflang (and <base in one case) is percent encoded, the other is not.
Patch: all links are now pure UTF8. No more percent encoding.
Instead of
<link href="http://localhost:8888/testwindows/trunkgitnew/fr/instructions-multilangue/33-ultimes-v%C3%A9rifications.html" rel="alternate" hreflang="fr-FR" />
<link href="http://localhost:8888/testwindows/trunkgitnew/en/multi-lingual-steps-by-steps/34-last-checks.html" rel="alternate" hreflang="en-GB" />
You will now get
<link href="http://localhost:8888/testwindows/trunkgitnew/fr/instructions-multilangue/33-ultimes-vérifications.html" rel="alternate" hreflang="fr-FR" />
<link href="http://localhost:8888/testwindows/trunkgitnew/en/multi-lingual-steps-by-steps/34-last-checks.html" rel="alternate" hreflang="en-GB" />
when displaying one or the other associated item.
The base link will now be full utf8, example:
<base href="http://localhost:8888/testwindows/trunkgitnew/fr/instructions-multilangue/33-ultimes-vérifications.html" />
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Libraries Plugins Front End |
| Status | New | ⇒ | Pending |
Corrected the issue for menu items.
Now should work fine.
| Title |
|
||||||
This is not as simple as I thought... Help needed. :)
remains to see if urldecode $base is not a pb
| Category | Libraries Plugins Front End | ⇒ | Plugins Front End |
This PR now only takes care of the regression for associated menu items alternate and display as readable UTF8 the alternate links.
I have tested this item
tested on a multilingual site with english, french and hebrew
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11769.
I have tested this item
works using ultimes-vérifications
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11769.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11769.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-26 11:52:33 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Just found we still have an issue here. This PR solves ordinary items associations (articles, contacts, etc.) but NOT menu items associations (so in case of both we still have issues)
It looks like hreflang for menu items associations is broken when one alias is utf8 and contains non latin glyphs (Russian, Greek, Macedonian, Tamil)