Joomla! Issue Tracker | Joomla! CMS #11760 - Fix Media field lightbox in subform

Fixed in Code Base
24 Aug 2016
Medium
Build: staging
# 11760
Diff
ciar4n:patch-1

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

ciar4n
23 Aug 2016

Pull Request for Issue #11755

Summary of Changes

This PR fixes a media field lightbox issue when additional subforms are added extending the page height. This results in the lightbox background no longer filling the page. Setting the lightbox background div (#sbox-overlay) to 'fixed' ensures the background remains within the viewport regardless of the page height.

Testing Instructions

Create ../modules/mod_login/text.xml to which add the following...

<?xml version="1.0" encoding="UTF-8"?>
<form>
    <fieldset name="images" class="image-subform">
        <field name="image" type="media" default="" label="Label1"  description="Desc1" size="30" />
        <field name="text" type="textarea" filter="raw" rows="10" cols="42" default="" label="Label2" description="Desc2" />
    </fieldset>
</form>

Add the following to the mod_login.xml file:

<field name="subformtest" type="subform" formsource="modules/mod_login/text.xml" class="advancedSelect" min="1" max="50" multiple="true" layout="joomla.form.field.subform.repeatable" groupByFieldset="true" label="Image(s)" description="Add image(s) to display in gallery" />

Then in the Module Manager, open the Login module. Add a number of subforms extending the page height. Click 'Select' in the last subform.

Before patch