User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Add missing css class row
to the file '/components/com_contact/views/category/tmpl/default_items.php' for unpublished contacts.
On admin panel:
1) Create some test contacts, unpublish a few of them.
2) Create test menu item of type 'Contacts' - 'List Contacts in a Category'.
3) Set the style 'protostar' as default.
On site:
1) Login as administrator.
2) Go to the test page.
None
Category | ⇒ | Front End Components |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
This fixes the issue but it pushes the background of the row outside the parent container. Not sure who did the markup for this initially but they need to understand the use of a row.
The row
class should be removed from all <li>
elements and properly fixed
i think it was like that before.
Either replace all the row
classes on <li>
elements with clearfix
....OR...because the grid systsem needs to be applied, don't use a list
I have tested this item
I have tested this item
Thanks for updating the markup ;)
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Needs Review |
Labels |
I don't think we can change the markup and replace an ul with a table
Labels |
Removed:
?
|
set to needs review, because I have too look what is our policy for template changes. If someone knows it out of his head please set the milestone
6.1.7 Rendered markup
For the time being, rendered markup is not subject to our backwards
compatibility promise. We will try not to change markup in such a way that
a site might render differently, but we can't promise not to break anything
at the present time. We will work on defining ways in which we might make a
backwards compatibility promise for markup in the future, but we do not
currently have a satisfactory consensus on a workable standard.
Thanks @brianteeman
Its a tricky one as we quite often accept PR that will change the rendered markup - although usually in very subtle ways. I tend to think changing a ul to a table is not a subtle way and "could" have a bigger impact. That being said I am edging more in favour of this PR as its a clear bug and it is a relatively less used page. (I wouldnt be in favour of a change to com_content lists)
@brianteeman If replace list-striped
with row-striped
for ul
and replace row
with row-fluid
for li
we can keep the old markup, but this solution has a little bug marked of the red arrow. If this solution is acceptable I can commit it to PR.
That can also work. The width is not correct because someone tried to be clever and use:
.row-striped .row-fluid {
width: 97%;
}
when it should be:
.row-striped .row-fluid {
width: 100%;
box-sizing: border-box;
}
If you want to submit a PR with your changes and the CSS change I've given you above, I'll be in favour of it.
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-26 12:18:24 |
Closed_By | ⇒ | nvyush |
I have tested this item✅ successfully on fe29aed
reproduced issue.
patch works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11753.