Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11748] - Test fixes

? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
23 Aug 2016

Summary of Changes

  • Tests in JHtml classes are flaky because the configuration is not mocked; if the "live" config is used and in debug mode this can cause test failures due to the wrong file being loaded
  • Fix for PHP 7.1 - Backports joomla-framework/google-api@43e6400 to fix the test case incorrectly injecting a string value when the method is expecting an integer

Testing Instructions

  • Unit tests continue to pass

Documentation Changes Required

N/A

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2016
Category ⇒ Unit Tests
avatar mbabker mbabker - open - 23 Aug 2016
avatar mbabker mbabker - change - 23 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 23 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Aug 2016

I have tested this item ✅ successfully on 4412fea

tests passed

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11748.

avatar zero-24
zero-24 - comment - 23 Aug 2016

@mbabker is it expected that PHP7.1 still fails?

avatar wilsonge wilsonge - change - 23 Aug 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-23 10:43:52
Closed_By ⇒ wilsonge
avatar wilsonge
wilsonge - comment - 23 Aug 2016

@zero-24 yes. See #11523

Add a Comment

Login with GitHub to post a comment