[#11744] - Typecast the profiler's memory marks to floats
- Fixed in Code Base
- 22 Aug 2016
- Medium
- Build: staging
- # 11744
- Diff
- mbabker:php71-fix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
On PHP 7.1 a A non-numeric value encountered warning is raised on these lines. The values are used for arithmetic operations so need to be numeric types first.
The issue is caused because JProfiler::mark() creates mark objects that prefix the time and memory values with a "+" or "-" symbol and the "+" symbol isn't allowed with numeric types. Since these aren't explicitly typecasted before the arithmetic operation (either by us or by PHP), it seems a change in 7.1 causes these new warnings.
Testing Instructions
Enable debug mode and the debug plugin. It should still work with correct output pre- and post- patch. If running a PHP 7.1 environment, you should be able to confirm the warning goes away.
Documentation Changes Required
N/A
joomla-cms-bot
- | Category | ⇒ | Plugins Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-22 22:30:08 |
| Closed_By | ⇒ | wilsonge |
Merged on review