[#1174] - Fix to JLog::add() method calling in Folder creation error handler
- Closed
- 28 May 2013
- Medium
- Build: master
- # 1174
- Diff
- PhilETaylor:LogFunctionCallError
- Error default The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Red Herring Error Message: DateTime::__construct(): Failed to parse time string (jerror) at position 0 (j): The timezone could not be found in the database
when failing to make a folder on installing an extension.
Looks like one of the commas should have been a period to concat the error message, other error messages are passed through JText::_ but this one is not, and the language string has no place for the path so looks like someone just removed JText::_ call but left in the comma.
All this PR does is remove the comma.
There are a lot of posts about this in the forum, and blog posts. Most give incorrect/false solutions.
Ref: http://sos82.net/coding/8-joomla-3-0-error-about-datetime-while-create-folder.html
yeah yeah I know - 11 commits to change a comma into a period - gessh I need coffeeeeeee!
Fix allows to track down my problem:
0 DateTime::__construct(): Failed to parse time string (jerror) at position 0 (j): The timezone could not be found in the database
To:
0 Cannot open file for writing log
Thanks! I can confirm that it works.
thats correct, there are so many red herrings on the web - but the correct solution is the one I propose, which then logs the root error message correctly :)
I looked the changes a bit closer and it looks like patch doesn't match to the change:
I know thats wrong, the ONLY file that is changed is here:
https://github.com/joomla/joomla-cms/pull/1174/files#diff-0
(sorry for my sloppy PR, I obviously needed more coffee)
This was merged in a separate commit.
http://code.joomla.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30945