Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11736] - [plg_system_logout] Load language files only when needed

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
22 Aug 2016

Pull Request for Issue #11714 (part 3).

Summary of Changes

Only load the plg_system_logout language file when they are needed.

For more info see #11714

Testing Instructions

Reproduce

  • Use latest staging
  • Enable plugin system logout (if not yet)
  • Enable debug and debug lang in global config
  • Enable debug system plugin with all options activated
  • Go to frontend and check the debug console
  • Notice JROOT/administrator/language/en-GB/en-GB.plg_system_logout.ini is loaded no matter what page you are (even in backend pages they are loaded).

image

Test patch

Documentation Changes Required

None.

Notes

This also solves a PHP warning when handling error on logout
Warning: Parameter 1 to PlgSystemLogout::handleError() expected to be a reference, value given in /path/to/joomla-staging/libraries/legacy/error/error.php on line 781

@mbabker please check this one also. Maybe this could be done without JError...

avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Category ⇒ Plugins Front End
avatar andrepereiradasilva andrepereiradasilva - open - 22 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 22 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 22 Aug 2016
avatar dgt41
dgt41 - comment - 22 Aug 2016

@andrepereiradasilva can you fix the CS:

FILE: /home/travis/build/joomla/joomla-cms/plugins/system/logout/logout.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 90 | ERROR | Usage of "$this" in static methods will cause runtime errors
avatar csthomas csthomas - test_item - 9 Sep 2016 - Tested successfully
avatar csthomas
csthomas - comment - 9 Sep 2016

I have tested this item ✅ successfully on 0652138

On frontend and backend.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11736.

avatar sonalitailored sonalitailored - test_item - 14 Sep 2016 - Tested successfully
avatar sonalitailored
sonalitailored - comment - 14 Sep 2016

I have tested this item ✅ successfully on 0652138

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11736.

avatar sonalitailored
sonalitailored - comment - 14 Sep 2016

I have tested this successfully.
Please find attached snapscreen shot 2016-09-14 at 00 34 15screen shot 2016-09-14 at 00 34 43

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11736.

avatar zero-24 zero-24 - change - 14 Sep 2016
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 14 Sep 2016

RTC Thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11736.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 14 Sep 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-09-14 06:57:12
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 14 Sep 2016
avatar rdeutz rdeutz - merge - 14 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - close - 14 Sep 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment