Feeling Lucky
?
[#11730] - [plg_content_vote|pagebreak] Load language files only when needed
- Fixed in Code Base
- 25 Aug 2016
- Medium
- Build: staging
- # 11730
- Diff
- andrepereiradasilva:languaguefiles-not-needed
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11714 (part 2).
Summary of Changes
Only load the plg_content_pagebreak and plg_content_vote languages files when they are needed.
Example: don't load them if the show_vote is not active or there is no pagebreak class.
For more info see #11714
Testing Instructions
Reproduce
- Use latest staging
- Enable plugin content vote and plugin content pagebreak
- Enable debug and debug lang in global config
- Enable debug system plugin with all options activated
- Go to frontend and check the debug console
- Notice
JROOT/administrator/language/en-GB/en-GB.plg_content_vote.iniandJROOT/administrator/language/en-GB/en-GB.plg_content_pagebreak.inilanguage file is loaded no matter what page you are (even in backend pages they are loaded).
Test patch
- Apply patch
- Repeat the steps above and checkthe two language files are NOT loaded (except when needed).
- Check plugin work as before if language files are required to load (ex: show_vote enabled / article with pagebreak, etc).
Documentation Changes Required
None.
joomla-cms-bot
- | Category | ⇒ | Plugins Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | Plugins Front End | ⇒ | Libraries Plugins Front End |
mbabker
- comment
- 22 Aug 2016
Looks fine.
andrepereiradasilva
- comment
- 22 Aug 2016
thanks
alikon
- comment
- 22 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11730.
jeckodevelopment
- comment
- 22 Aug 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11730.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 22 Aug 2016
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-25 20:24:02 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@mbabker i updated this PR to follow the logic you added for modules in #11698, but this time for the plugins.
Can you check if all ok?