Did some quick testing. Overall, looks good on a default install. Just two suggestions at this point:

1) Customize the Makefile to our environment. You copied the one from the Bootstrap repo which is trying to compile everything; since we aren't building their docs site or compiling the CSS with it, we don't need those sections in there.
2) I'd take the LESS files out of build/bootstrap. They're just extra copies of the files that we don't need in the repo; all of our compiling uses those found in the media/jui folder.

I'm looking at the latest docs and am working to update the JHtmlBootstrap class to accomodate any changes in the JavaScript objects; I'll send a PR your way when I've finished that.

There,s also a fix to Isis less files. A path is wrong.

A
El 21/05/2013 22:20, "Michael Babker" notifications@github.com escribió:

Did some quick testing. Overall, looks good on a default install. Just two
suggestions at this point:

1) Customize the Makefile to our environment. You copied the one from the
Bootstrap repo which is trying to compile everything; since we aren't
building their docs site or compiling the CSS with it, we don't need those
sections in there.
2) I'd take the LESS files out of build/bootstrap. They're just extra
copies of the files that we don't need in the repo; all of our compiling
uses those found in the media/jui folder.

I'm looking at the latest docs and am working to update the JHtmlBootstrap
class to accomodate any changes in the JavaScript objects; I'll send a PR
your way when I've finished that.

—
Reply to this email directly or view it on GitHub#1172 (comment)
.

Note: the bootstrap_rtl.less file in the build folder is extremely different from the one we have in jui

bootstrap_rtl.less is not being updated in this PR.

A

Ups, yes, bootstrap_rtl.less is included in the PR... but they are identical. Please, confirm which are the differences.

@anibalsanchez could you merge my PR on your repo in please? That updates the JHtmlBootstrap class to match Bootstrap 2.3.2 in terms of JavaScript support. With that, in terms of file structure, I think everything is good to go. We just need to have some folks test and make sure that in terms of style, everything displays properly with the update.

What about adding Bootstrap version to JVersion?

For example:

public $BOOTSTRAP = '2.3.2';

public function getBootstrapVersion()
{
    return $this->BOOTSTRAP;
}

I think this could help extension developer in preparing to changes in markup, at least in switch to Bootstrap 3.x.

At the moment Bootstrap version is available only as a string in the media/jui/ asset files (.css, .less, .js)

My reason is that less.js 1.4 doesn't like Bootstrap 2.1.0 code.

Propose it on list and see how it's taken. I personally don't see the issue with it.

Started New topic at:
Joomla CMS Development: Bootstrap version in JVersion