[#11713] - [joomla update captive] use JAuthenticationHelper::getTwoFactorMethods()
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 11713
- Diff
- andrepereiradasilva:patch-17
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Same as done in #11667 and #11684, but this time for the com_joomlaupdate "Upload & Install".
Testing Instructions
Mainly code review, but to actually test it:
1. Use latest staging
2. Apply patch
3. Try to use 2FA to login in backend and frontend (check "How to test 2FA" in the end of the PR description)
4. Use https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip and try to update joomla wuth "Update & Install"
5. Code review
Documentation Changes Required
None.
How to test 2FA
- Enable Google Authenticator two factor authentication plugin: Extensions > Plugins (twofactorauth)
- Create a dummy user and configure it to use with Google Authenticator: Users > Manage > Edit (2FA tab)
Note: you can use a chrome plugin for configuring and using 2FA, for instance https://chrome.google.com/webstore/detail/authenticator/bhghoamapcdpbohphigoooaddinpkbai
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 21:10:40 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 9b2a967
On review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11713.