? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
21 Aug 2016

Pull Request for Simplify Travis CI testing by only using mysql root .

Summary of Changes

Simplify Travis CI testing by only using mysql root

This eliminates the HHVM and non-HHVM specific mysql database creations. By using only the root option we have a simpler testing setup.

Testing Instructions

merge by code review

Documentation Changes Required

none

avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2016
Category Repository
avatar photodude photodude - open - 21 Aug 2016
avatar photodude photodude - change - 21 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 21 Aug 2016
Category Repository Repository Unit Tests
avatar andrepereiradasilva andrepereiradasilva - test_item - 21 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Aug 2016

I have tested this item successfully on 8754ce0

seems logic to me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

avatar photodude
photodude - comment - 23 Aug 2016

@rdeutz, @mbabker, @wilsonge, can this get a bump for merge consideration

avatar rdeutz rdeutz - test_item - 24 Aug 2016 - Tested successfully
avatar rdeutz
rdeutz - comment - 24 Aug 2016

I have tested this item successfully on 8754ce0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2016
Category Repository Unit Tests Repository
avatar rdeutz rdeutz - change - 24 Aug 2016
Status Pending Ready to Commit
avatar rdeutz
rdeutz - comment - 24 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2016
Labels Added: ?
avatar yvesh
yvesh - comment - 24 Aug 2016

@photodude how about moving that create database into the sql file? That would simplify it even more ;)

avatar mbabker
mbabker - comment - 24 Aug 2016

? the SQL file is used for more than Travis and the database name is configurable via the DSN strings for each instance.

avatar rdeutz rdeutz - change - 25 Aug 2016
Status Ready to Commit Needs Review
Labels
avatar rdeutz
rdeutz - comment - 25 Aug 2016

set to needs review for double checking the patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2016
Labels Removed: ?
avatar photodude
photodude - comment - 25 Aug 2016

@rdeutz I'm not sure I'm following, what needs to be reviewed with the patch?

avatar rdeutz
rdeutz - comment - 26 Aug 2016

@photodude the comment @mbabker makes me wonder if this the right thing to do, so I removed RTC to make sure it doesn't gets merged by accident and give me some time to check again.

avatar mbabker
mbabker - comment - 26 Aug 2016

My comment was in response to @yvesh suggesting the CREATE DATABASE statement be moved into the SQL files, not the root user change.

avatar rdeutz
rdeutz - comment - 26 Aug 2016

Ah, thought better look twice than sorry :-) So we can merge this.

avatar rdeutz rdeutz - change - 26 Aug 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-26 12:49:39
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Aug 2016
avatar rdeutz rdeutz - merge - 26 Aug 2016
avatar photodude
photodude - comment - 26 Aug 2016

Thanks @rdeutz

Add a Comment

Login with GitHub to post a comment