[#11694] - 3.7.0: Using the new modal_menu field in various core places
- Fixed in Code Base
- 28 Aug 2016
- Medium
- Build: 3.7.x
- # 11694
- Diff
- infograf768:3.7.x-menumodalnames
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR completes 1f48268
By implementing the new modal_menu field in various places in core.
Menu item Alias
Menu item Login form: login redirect and logout redirect
Menu Item Logout
Module mod_login (frontend) for login and logout redirect
Module mod_menu (frontend) Base Item
Remarks:
- The code adapts itself to the
<option value="">STRING_CONSTANT</option>in the field.
i.e. when JDEFAULT or JCURRENT is used.
<field
name="login"
type="modal_menu"
label="MOD_LOGIN_FIELD_LOGIN_REDIRECTURL_LABEL"
description="MOD_LOGIN_FIELD_LOGIN_REDIRECTURL_DESC"
disable="separator,alias,heading,url"
edit="true"
clear="true"
>
<option value="">JDEFAULT</option>
</field>Here when JCURRENT is used (See screenshots above when it is JDEFAULT):
- For multilanguage Associations, it keeps
COM_MENUS_SELECT_A_MENUITEM
- When selecting a menu item through the modal, we now display the forced language concerned in the title of the modal when we make associations:
TODO:
- Add also the language name to the modal title when using forced language in other core components.
- Add a new editors-xtd letting enter menu item links in content via new button in the editor (Already done here, will post soon)
What is the purpose have having separate buttons for select/edit
As we already do in core:
Select lets select an item in a modal list
Edit lets edit the item selected in another modal once the original item has been saved.
We already do that for articles, etc.
BTW, Travis failure looks unrelated to this PR:
PHP Fatal error: Call to a member function children() on null in /home/travis/build/joomla/joomla-cms/libraries/joomla/form/fields/text.php on line 187
Ah sorry. Got it now.
Select = select item
Edit = edit the selected item
I was thinking that
Edit = edit the selection ie make a new selection
| Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
| Milestone |
Added: |
||
I have tested this item
Also tested if ACL was working, it was :D
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11694.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11694.
| Status | Pending | ⇒ | Ready to Commit |
RTC
@wilsonge we have issues with Travis which look unrelated to this PR as well as to #11721
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11694.
hmm rtc set on issues does not get it here
@brianteeman can you help here?
joomla-cms-bot
- | Category | Administration | ⇒ | Administration Components Front End Modules |
| Labels |
Added:
?
|
||
Manually set to RTC on github
tks
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-28 20:32:12 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@brianteeman
Can you please set milestone to 3.7.0