[#11676] - Load template language files if able in JDocumentError
- Fixed in Code Base
- 20 Aug 2016
- Medium
- Build: staging
- # 11676
- Diff
- mbabker:Error-Template-Lang-Files
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Depending on where in the order of operations things are at, it's possible to hit the error page before anything loads the template's language files. And JDocumentError isn't loading them either, which can cause untranslated strings to appear. So, load the files if we are able to do so (i.e. a JLanguage object is set to the factory; we won't try to load JLanguage into the factory in case that's the cause of the error).
Testing Instructions
Find a template with language strings in its error page; the core templates have this. For the frontend app, add a throw new RuntimeException('Testing language PR'); line in to JApplicationSite::doExecute() after it's called the initialiseApp() method. Pre-patch, it may or may not have translated strings (I couldn't duplicate this consistently locally but we hit it on the volunteers portal). Post-patch, it should most likely be translated (it only wouldn't if the error triggering the error page came from instantiating JLanguage basically).
Documentation Changes Required
N/A
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11676.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
good progress! ... one can only hope one day the JDocumentError will also be able to load the css and js scripts/files ... :)
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-20 12:13:33 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on e9b7dc1
Tested with protostar and isis templates
e.g. adding to file:
administrator/templates/isis/error.php
a template language string fron: administrator/templates/isis/language/en-GB/en-GB.tpl_isis.ini
it gets translated after applying the PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11676.