For me this is going to make it very confusing as the only date that is displayed is the created date. So as soon as people start to use these new sorts they will wonder why it doesnt work as the Date column does not reflect the ordering

I think it is not confusing, because Start Publishing ascending and Date ascending are two different thing.

Yes you can't see the sort column, but it is quite logic what is mean it think so

I agree with Brian here. If we start manipulating again the ordering system we get riots on the forums and sorry @n9iels I disagree with it. It is not logic but confusing

@n9iels they are different things but if a user doesnt see it as there is a no column I can guarantee they will be confused

@gwsdesk this is nothing to do with front end ordering

Hmm true...
What if we changed that column of the filter is on? So if we filter on start published date the "date" column is replaced by the start published date. Or will that be confusing too?

In my opinion yes

On 24 August 2016 at 09:25, Niels van der Veer notifications@github.com
wrote:

Hmm true...
What if we changed that column of the filter is on? So if we filter on
start published date the "date" column is replaced by the start published
date. Or will that be confusing too?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11670 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fbEkGT4cI9AZWg3ZNLOrGdntpTXks5qi__egaJpZM4JojEB
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I did not say frontend. I thought this is meant for admin ordering so if
I am mistaken me sorry

On 8/24/2016 3:18 PM, Brian Teeman wrote:

@n9iels https://github.com/n9iels they are different things but if a
user doesnt see it as there is a no column I can guarantee they will
be confused

@gwsdesk https://github.com/gwsdesk this is nothing to do with front
end ordering

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11670 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHzLNpniQ9facFehQ4X4qThb11Xm8hwxks5qi_4_gaJpZM4JojEB.

For people that are working heavily with scheduled articles it does makes a lot of sense to be able to order the backend articles list on the publication date. They don't even look at the creation date. At the moment there is no possibility to see the (upcoming) articles in the backend ordered by the publication date, while many frontend views are using the publication date as ordering. It would be great to display articles in the same order as on the frontend.

I do think that @n9iels suggestion of changing the "Date" column in the overview based on the filtering selection. So for all people used to the current listing nothing will change.

As soon as someone selects the "Publishing date" (the suggested new option) in the filter the date column shows the Publishing date instead of the Creation date. I would only recommend to change "Date" column heading into "Date Created" heading, right now it is not clear what date is displayed anyway.

@sanderpotjer you've convinced me - so if the date column changes are added to this PR then it can be tested

@sanderpotjer @brianteeman I changed the position of the publish_up filter in the select list. When the filter is applied the publish_up dates are visible instead of the created dates. Also the heading is different when the filter is applied

I have tested this item ? unsuccessfully on 0a3c98f

PHP Parse error: syntax error, unexpected ';', expecting ':' in /administrator/components/com_content/views/articles/tmpl/default.php on line 86

@brianteeman @zero-24 I fixed the syntax error.

Offtopic: Why didn't Travis mention this error?

IIRC Travis complete ignore the tmpl folders ;)

I have tested this item ? unsuccessfully on e5a42f3

1. Set filter to Start Publishing Ascending in the filter and the column header says Date Created

1. Set filter to Finish Publishing Ascending in the filter and the column header says Date Created

2. When the filter is set to Finish Publishing and an item does not have a finish publishing date (most will not) then the value displayed is -0001-11-30

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11670.}

Offtopic: Why didn't Travis mention this error?

IIRC Travis complete ignore the tmpl folders ;)

They aren't completely ignored, just the code standard checks mostly. We don't have a check for valid syntax in the files though.

They aren't completely ignored, just the code standard checks mostly. We don't have a check for valid syntax in the files though.

Thanks for corrcting me. Here is a a RFC for PHP Syntax checker #12379

Please consider my suggestion from n9iels#5

@csthomas @n9iels Maybe it would be even easier to declare the $orderingColumn at the top and fill it via a regex (or substr), instead of setting it somewhere and using it somewhere else. You could then also skip the strpos and immediately do if (orderingColum == publish_up)?

@euismod2336 As you wish n9iels#5

The same changes should be added to https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/html/com_content/articles/default.php

Hathor doesn't provide an option to sort on date, so I only changed the language string so that it's more obvious the creation date is meant in the table.

I have tested this item ✅ successfully on f3c552b

What about featured articles view? It might be worthwhile to add the same?

You are correct, again :) thank you @csthomas

There is also JDATE at https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/html/com_content/featured/default.php#L108

@euismod2336 can you please fix the code conflict in administrator/components/com_content/views/articles/tmpl/default.php with the latest changes? Right now it is removing the latest changes around hits, votes & rating:

something seems terribly broken at this point...one moment :)

ignore previous comment, that was related to missing language files in my local copy. @sanderpotjer @marclight (i got your name from the related issue) could you give this a test run? Then maybe we can get this done before 2020 ;)

I have tested this item ✅ successfully on 5c43460

I have tested this item ✅ successfully on 5c43460

Thanks for this feature!

RTC