User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Simple change from string specifier %s to integer specifier %d in multiple strings.
Values for place holders are integers not strings - second param for JText::plurar() function, i.e. https://github.com/joomla/joomla-cms/blob/b2a4b483995875373da5b385011225358abeb571/libraries/legacy/controller/admin.php#L237
Code review
Category | ⇒ | Language & Strings Administration |
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
I don't know if its truly necessary - I just wanted to post this 'issue', ignore it (close) or not is not my call :)
I would be against using %d,
unless it is really 100% sure that we will never need to pass a string to it ...
e.g. i am doing this in my views (but i am not using these Joomla language strings, instead using my own)
4 out of 7 items were deleted
notice the:
4 out of 7
so if you want to make an addition to the existing code, you will have to change the language strings back to %s,
but then you have a problem:
unless existing strings are causing a problem, it is best not to do this, reverting it in the future, would be problematic !
I was thinking about it, that best way would be to use %s in every single key when param is passed to a string. But again it would be a pain for translators OR not replace %d with %s in multiple files is a simple procedure, even at Crowdin.
I am setting this to needs review so a decision can be made.
Status | Pending | ⇒ | Needs Review |
Labels |
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 13:41:04 |
Closed_By | ⇒ | rdeutz |
Although this is indeed correct theoretically speaking, it has no effect whatsoever on the resulting display. Is it really worth changing?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11662.