[#11655] - Сode optimization from issue #11643
- Fixed in Code Base
- 24 Aug 2016
- Medium
- Build: staging
- # 11655
- Diff
- nvyush:patch-1
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11643.
Summary of Changes
1) array(...) and in_array(...) replaced with more effective in that case bitwise operations.
2) initialization of $denied_states move before of the cycle.
Modifications of code are trivial and should not lead to side effects.
Testing Instructions
1) Create two test users e.g. 'test1' and 'test2'.
2) Set user 'test2' as blocked (set 'Accout Details' - 'Block this User' to 'Yes').
3) Try to login as user 'test1'. You should can do this.
4) Try to login as user 'test2'. You should get message "Login denied! Your account has either been blocked or you have not activated it yet." (JERROR_NOLOGIN_BLOCKED).
Documentation Changes Required
Not needed.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
I have tested it on J3.6.2 with com_patchtester.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I updated branch accidentally without changing any code. Please, recheck.
I have tested this item
The same as instruction say.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I have tested successfully.
I did not find any difference, everything works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I have created two user like "Test5" and "Test6" and set Test6 to blocked.
- I did not find any difference and working is fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-24 07:27:51 |
| Closed_By | ⇒ | rdeutz |
I have tested this item
i have tested successfully this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
@tomartailored This has already been merged - so either you are not testing with the current staging which you must always do or you didnt really test it but I am sure that you did didnt you
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.
I have tested this item✅ successfully on 2e28ca7
Installed a clean 3.6.3-dev.
Created user1 and user2, set user2 to blocked.
Logged in on frontend as user1: OK!
Logged in on frontend as user2: message as stated in this PR, access denied.
Applied the patch.
Created user3 and user4, set user4 to blocked.
Logged in on frontend as user3: OK!
Logged in on frontend as user4: message as stated in this PR, access denied.
Conclusion: I did not find any difference, everything works as expected. Tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11655.