[#11653] - Images folder for com_finder missing in media/com_finder
- Closed
- 18 Aug 2016
- Medium
- Build: master
- # 11653
Images folder for com_finder missing in media/com_finder in the joomla package.
See here :
https://github.com/joomla/joomla-cms/tree/staging/media/com_finder
And here:
administrator/components/com_finder/finder.xml
<media destination="com_finder" folder="media">
<folder>js</folder>
<folder>images</folder>
<folder>css</folder>
</media>
From what I can see the images folder was removed 4 years ago in 2.5.2 7dfcc78#diff-2f8cf9dc3b6c5ff920d1e5e10b5f6fb5
@brianteeman
Yes, indeed.
But the call to this folder is still present in finder.xml, as shown above and below, if you care to check.
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_finder/finder.xml
So, a choice has to be made.
@zero-24
I'd gladly do a pull request, but I don't think it is up to me to decide, even if it is a trivial matter.
Just do a PR to remove it from finder.xml
On 18 August 2016 at 11:30, ghazal notifications@github.com wrote:
@brianteeman https://github.com/brianteeman
Yes, indeed.
But the call to this folder is still present in finder.xml, as shown above
and below, if you care to check.
https://github.com/joomla/joomla-cms/blob/staging/
administrator/components/com_finder/finder.xml
So, a choice has to be made.@zero-24 https://github.com/zero-24
I'd gladly do a pull request, but I don't think it is up to me to decide,
even if it is a trivial matter.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11653 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dXVJxyrJb2sDoIC2zFIG9v17lzNks5qhDQ3gaJpZM4JnNJp
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-18 11:24:55 |
| Closed_By | ⇒ | brianteeman |
Can you send your changes as pull request? If you need help please double check https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests