Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11642] - Language filter alternate meta tags default value should be 1

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
17 Aug 2016

Summary of Changes

Language filter alternate meta tags parameter default is 1 so make it 1 as default also in the code.

Testing Instructions

Code review.
See also https://github.com/joomla/joomla-cms/blob/staging/plugins/system/languagefilter/languagefilter.xml#L57

Documentation Changes Required

None.

avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2016
Category ⇒ Plugins Front End
avatar andrepereiradasilva andrepereiradasilva - open - 17 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 17 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 17 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 17 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 17 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 17 Aug 2016
avatar infograf768
infograf768 - comment - 18 Aug 2016

@andrepereiradasilva
Associations or not, the alternate should display when we are on the home pages.
Example

<link href="http://localhost:8888/gsocmulti/it/" rel="alternate" hreflang="it-IT" />
    <link href="http://localhost:8888/gsocmulti/fr/" rel="alternate" hreflang="fr-FR" />
    <link href="http://localhost:8888/gsocmulti/" rel="alternate" hreflang="en-GB" />
avatar infograf768
infograf768 - comment - 18 Aug 2016

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string
PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC

avatar andrepereiradasilva andrepereiradasilva - change - 18 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 18 Aug 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 Aug 2016

Associations or not, the alternate should display when we are on the home pages.

Ok. removed that part from the code. now just sets the default as innitially

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC

please make a PR for that.

please test

avatar infograf768 infograf768 - test_item - 18 Aug 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 18 Aug 2016

I have tested this item ✅ successfully on 06e4a54

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

avatar infograf768
infograf768 - comment - 18 Aug 2016

will make pr

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

avatar jeckodevelopment jeckodevelopment - test_item - 18 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 18 Aug 2016

I have tested this item ✅ successfully on 06e4a54

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

avatar jeckodevelopment jeckodevelopment - change - 18 Aug 2016
Status Pending ⇒ Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 18 Aug 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 19 Aug 2016

See #11663

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

avatar wilsonge wilsonge - close - 19 Aug 2016
avatar wilsonge wilsonge - merge - 19 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 19 Aug 2016
avatar wilsonge wilsonge - change - 19 Aug 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-19 13:47:28
Closed_By ⇒ wilsonge
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment