I suppose you didn't use the Joomla! Update component to perform the update, right?

Even if you didn't if you hit the database fix button or run the CLI script
you can delete the old files. So some of these probably aren't in
script.php.

On Monday, August 15, 2016, Luca Marzo notifications@github.com wrote:

I suppose you didn't use the Joomla! Update component to perform the
update, right?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11616 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobY8o04_8IWJ6k3YpFxx778UEUTdks5qgHYggaJpZM4JkZeG
.

3.4.0 to 3.4.6 I used the old way via extension manager "update package"
for 3.4.6 to 3.5.0 and then to 3.6.2 I used method B as per
https://docs.joomla.org/J3.x:Upgrading_from_Joomla_3.4.x_to_3.5

I went in the current staging, those files no longer exists. I randomly checked 10 files in script.php and cannot locate them neither.

3.4.0 to 3.4.6 I used the old way via extension manager "update package"

As stated that is not a valid method for updating to 3.6

On 15 August 2016 at 15:30, Jean-Luc Subri notifications@github.com wrote:

3.4.0 to 3.4.6 I used the old way via extension manager "update package"
for 3.4.6 to 3.5.0 and then to 3.6.2 I used method B as per
https://docs.joomla.org/J3.x:Upgrading_from_Joomla_3.4.x_to_3.5

I went in the current staging, those files no longer exists.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11616 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b8a7L2JzMmMDAzR5D7XHewF6uBXks5qgHgKgaJpZM4JkZeG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Within 3.4.x that was supported. I used method B only for 3.5/3.6

not for upgrading to 3.6

On 15 August 2016 at 15:36, Jean-Luc Subri notifications@github.com wrote:

Within 3.4.x that was supported. I used method B only for 3.5/3.6

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11616 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8QxU7d9hcj5DReDIK5ekE8tLtMBOks5qgHldgaJpZM4JkZeG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sorry, forgot to use the "database fix button" after the last upgrade.
file list reduced to 74

34-to-362_new.xlsx

I am trying to replicate and check this

I have taken 3.4 and updated it to 3.6.3 using the update component and found the following list of deleted files

Does this match yours as I'm not opening an xlsx file from an unknown source

Comparison Report.pdf

Thank you for testing, I've reviewed your "Comparison Report.pdf" line by line. Looks to me the update component method went strait from 3.4.x to 3.6 an skipped the method B (for 3.5) which is leading to the below difference:

Missing in my file:

• components/com_joomlaupdate.dir

Missing in your file:

• media/editors/codemirror/mode/kotlin/kotlin.min.js - kotlin.dir doesn't exists anymore.

For B/C purpose, the logs/. to be skipped (not needed in script.php
With the above 3 caveats we are aligned.

P.S I've not digged further if the "robots.txt.dist" in the root directory need to be removed too.

The real concern is that we can add all the files that need to be removed
to
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/script.php#L412

On 15 August 2016 at 21:41, Jean-Luc Subri notifications@github.com wrote:

Thank you for testing, I've reviewed your "Comparison Report.pdf" line by
line. Looks to me the update component method went strait from 3.4.x to 3.6
an skipped the method B (for 3.5) which is leading to the below difference:

Missing in my file:

• components/com_joomlaupdate.dir

Missing in your file:

• media/editors/codemirror/mode/kotlin/kotlin.min.js - kotlin.dir doesn't exists anymore.

For B/C purpose, the logs/. to be skipped (not needed in script.php
With the above 3 caveats we are aligned.

P.S I've not digged further if the "robots.txt.dist" in the root directory
need to be removed too.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11616 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YAGyoN915vJJxMWcLzsqw8T9jxUks5qgM7zgaJpZM4JkZeG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

P.S I've not digged further if the "robots.txt.dist" in the root directory need to be removed too.

It honestly could probably be excluded from update packages in general. Same with htaccess.txt and web.config.txt. All three of those files are usually renamed when a site is set up to what they should be for production purposes.

RE: The real concern is that we can add all the files that need to be removed

I would vote to add a generic cleanup section after line 1429 and not going back in time with the exact release number as when the files got obsolete.

I think thats going to be the only way - anything else sounds like it will
be a waste of the creators time

On 15 August 2016 at 22:03, Jean-Luc Subri notifications@github.com wrote:

RE: The real concern is that we can add all the files that need to be
removed

I would vote to add a generic cleanup section after line 1429 and not
going back in time with the exact release number as when the files got
obsolete.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11616 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Ub5_8Ksh6W2y1Tv6IfDMmHHpm3Zks5qgNQdgaJpZM4JkZeG
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

robots.txt.dist, htaccess.txt, web.config.txt

I would prefer not to delete them or remove them from update packages. Thus you always have the newest, recommended and "cleanest" version in your installation for comparison and so on.

I would prefer to keep files grouped by Joomla version (= chronological and documented order) as is now (if it's not a waste of time for people that maintain the list). Thus you always have an informative list about LAST changes of directory/files structure. If I need an ordered list by name for investigations I can order the entries. Not a problem with PHP or EXCEL or ....

I don't see any real benfits in changing it.

The problem @bertmert is someone is going to have to go through all those
files and work out when they were removed. They should have been added at
the time but for whatever reason they weren't

going back to 3.4.1, 3.4.2... would be a nightmare especially for the frequent changing libraries such as tinymce, codemirror...
I can try a PR provided their is a shared view on having a single clean-up section for files and one for the directories.

If you check out each release tag and run the build script, it generates a list of deleted files based on the git file comparison from previous releases. If you're going to go this way though, make sure you're not running Git 2.9 (our build script only got updated to support its B/C breaking changes with this last release).

@mbabker, I'm afraid this is well above my capabilities, I can only do simple stuff on Eclipse/git. I added the below entries in script.php, run the database fix and ended-up with the same number of files compared with 3.6.2.

        // Joomla 3.6.3 - cleanup section for missed files between 3.4.0 and 3.6.2
        '/administrator/components/com_config/controller/application/refreshhelp.php',
        '/administrator/components/com_media/models/forms/index.html',
        '/administrator/templates/hathor/html/com_categories/categories/default_batch.php',
        '/administrator/templates/hathor/html/com_tags/tags/default_batch.php',
        '/images/joomla_black.gif',
        '/images/joomla_green.gif',
        '/images/joomla_logo_black.jpg',
        '/libraries/fof/LICENSE.txt',
        '/libraries/joomla/application/web/client.php',
        '/libraries/joomla/database/iterator/azure.php',
        '/media/com_banners/banner.js',
        '/media/com_finder/css/finder-rtl.css',
        '/media/com_finder/css/selectfilter.css',
        '/media/com_finder/css/sliderfilter.css',
        '/media/com_finder/js/sliderfilter.js',
        '/media/editors/codemirror/lib/addons-uncompressed.js',
        '/media/editors/codemirror/lib/codemirror-uncompressed.css',
        '/media/editors/codemirror/lib/codemirror-uncompressed.js',
        '/media/editors/codemirror/mode/clike/scala.html',
        '/media/editors/codemirror/mode/css/less.html',
        '/media/editors/codemirror/mode/css/less_test.js',
        '/media/editors/codemirror/mode/css/scss.html',
        '/media/editors/codemirror/mode/css/scss_test.js',
        '/media/editors/codemirror/mode/css/test.js',
        '/media/editors/codemirror/mode/gfm/test.js',
        '/media/editors/codemirror/mode/haml/test.js',
        '/media/editors/codemirror/mode/javascript/json-ld.html',
        '/media/editors/codemirror/mode/javascript/test.js',
        '/media/editors/codemirror/mode/javascript/typescript.html',
        '/media/editors/codemirror/mode/kotlin/kotlin.js',
        '/media/editors/codemirror/mode/kotlin/kotlin.min.js',
        '/media/editors/codemirror/mode/markdown/test.js',
        '/media/editors/codemirror/mode/php/test.js',
        '/media/editors/codemirror/mode/ruby/test.js',
        '/media/editors/codemirror/mode/shell/test.js',
        '/media/editors/codemirror/mode/slim/test.js',
        '/media/editors/codemirror/mode/smartymixed/smartymixed.js',
        '/media/editors/codemirror/mode/stex/test.js',
        '/media/editors/codemirror/mode/textile/test.js',
        '/media/editors/codemirror/mode/verilog/test.js',
        '/media/editors/codemirror/mode/xml/test.js',
        '/media/editors/codemirror/mode/xquery/test.js',
        '/media/editors/tinymce/plugins/compat3x/editable_selects.js',
        '/media/editors/tinymce/plugins/compat3x/form_utils.js',
        '/media/editors/tinymce/plugins/compat3x/mctabs.js',
        '/media/editors/tinymce/plugins/compat3x/tiny_mce_popup.js',
        '/media/editors/tinymce/plugins/compat3x/validate.js',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon.eot',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon.svg',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon.ttf',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon.woff',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.eot',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.svg',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.ttf',
        '/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.woff',
        '/media/editors/tinymce/skins/lightgray/fonts/readme.md',
        '/media/editors/tinymce/skins/lightgray/fonts/tinymce.dev.svg',
        '/media/editors/tinymce/skins/lightgray/fonts/tinymce-small.dev.svg',
        '/media/editors/tinymce/skins/lightgray/img/wline.gif',
        '/media/mod_languages/images/km_kr.gif',
        '/media/mod_languages/images/si_lk.gif',
        '/plugins/editors/codemirror/styles.css',
        '/plugins/editors/codemirror/styles.min.css',
        '/plugins/editors/tinymce/fields/skins.php',
        '/plugins/user/profile/fields/dob.php',
        '/plugins/user/profile/fields/tos.php',

        // Joomla 3.6.3 - cleanup section for missed directories between 3.4.0 and 3.6.2
        '/administrator/components/com_media/models/forms',
        '/components/com_joomlaupdate',
        '/media/com_banners',
        '/media/editors/codemirror/mode/kotlin',
        '/media/editors/codemirror/mode/smartymixed',
        '/media/editors/tinymce/plugins/compat3x',
        '/plugins/editors/tinymce/fields',
        '/plugins/user/profile/fields',

I ran the build scripts (or tried to) so far I got this info

// Joomla 3.4.1
media/editors/codemirror/lib/addons-uncompressed.js
media/editors/codemirror/lib/codemirror-uncompressed.css
media/editors/codemirror/lib/codemirror-uncompressed.js

// Joomla 3.4.2
administrator/templates/hathor/html/com_categories/categories/default_batch.php
administrator/templates/hathor/html/com_tags/tags/default_batch.php
libraries/ClassLoader.php
libraries/composer_autoload.php
libraries/fof/LICENSE.txt
libraries/fof/download/adapter/cacert.pem
media/editors/codemirror/addon/runmode/runmode.node.min.js
media/editors/codemirror/mode/clike/scala.html
media/editors/codemirror/mode/css/less.html
media/editors/codemirror/mode/css/less_test.js
media/editors/codemirror/mode/css/less_test.min.js
media/editors/codemirror/mode/css/scss.html
media/editors/codemirror/mode/css/scss_test.js
media/editors/codemirror/mode/css/scss_test.min.js
media/editors/codemirror/mode/css/test.js
media/editors/codemirror/mode/css/test.min.js
media/editors/codemirror/mode/gfm/test.js
media/editors/codemirror/mode/gfm/test.min.js
media/editors/codemirror/mode/haml/test.js
media/editors/codemirror/mode/haml/test.min.js
media/editors/codemirror/mode/javascript/json-ld.html
media/editors/codemirror/mode/javascript/test.js
media/editors/codemirror/mode/javascript/test.min.js
media/editors/codemirror/mode/javascript/typescript.html
media/editors/codemirror/mode/markdown/test.js
media/editors/codemirror/mode/markdown/test.min.js
media/editors/codemirror/mode/php/test.js
media/editors/codemirror/mode/php/test.min.js
media/editors/codemirror/mode/ruby/test.js
media/editors/codemirror/mode/ruby/test.min.js
media/editors/codemirror/mode/shell/test.js
media/editors/codemirror/mode/shell/test.min.js
media/editors/codemirror/mode/slim/test.js
media/editors/codemirror/mode/slim/test.min.js
media/editors/codemirror/mode/smartymixed/smartymixed.js
media/editors/codemirror/mode/smartymixed/smartymixed.min.js
media/editors/codemirror/mode/stex/test.js
media/editors/codemirror/mode/stex/test.min.js
media/editors/codemirror/mode/textile/test.js
media/editors/codemirror/mode/textile/test.min.js
media/editors/codemirror/mode/verilog/test.js
media/editors/codemirror/mode/verilog/test.min.js
media/editors/codemirror/mode/xml/test.js
media/editors/codemirror/mode/xml/test.min.js
media/editors/codemirror/mode/xquery/test.js
media/editors/codemirror/mode/xquery/test.min.js

// Joomla 3.4.3
libraries/classloader.php

// Joomla 3.4.4
media/com_banners/banner.js
media/jui/img/ajax-loader.gif
media/mod_languages/images/km_kr.gif

// Joomla 3.6.1
libraries/joomla/database/iterator/azure.php

@jusubri can you compare that to your list please and let me know which files are still missing from the list

Dear Brian,

You caught more files than me :-)

Summary, your list is good, however certain files shall not be removed see below.

FILES
// Joomla 3.4.0 FOR DELETE CONSIDERATION
/media/editors/tinymce/skins/lightgray/fonts/icomoon.svg',
/media/editors/tinymce/skins/lightgray/fonts/icomoon.ttf',
/media/editors/tinymce/skins/lightgray/fonts/icomoon.woff',
/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.eot',
/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.svg',
/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.ttf',
/media/editors/tinymce/skins/lightgray/fonts/icomoon-small.woff',
/media/editors/tinymce/skins/lightgray/fonts/readme.md',
/media/editors/tinymce/skins/lightgray/fonts/tinymce.dev.svg',
/media/editors/tinymce/skins/lightgray/fonts/tinymce-small.dev.svg',
/media/editors/tinymce/skins/lightgray/img/wline.gif',
/plugins/editors/codemirror/styles.css',
/plugins/editors/codemirror/styles.min.css',

// Joomla 3.4.2 DO NOT DELETE
libraries/fof/download/adapter/cacert.pem, => don't delete,part of #11673

// Joomla 3.4.2 FOR DELETE CONSIDERATION
images/joomla_black.gif', Backward compatibility?
mages/joomla_green.gif', Backward compatibility?
images/joomla_logo_black.jpg', Backward compatibility?

// Joomla 3.4.4 DO NOT DELETE
media/jui/img/ajax-loader.gif dont delete, part of #8201

// Joomla 3.5.0 FOR DELETE CONSIDERATION
/media/editors/tinymce/plugins/compat3x/editable_selects.js', deleted as part of #7667
/media/editors/tinymce/plugins/compat3x/form_utils.js', deleted as part of #7667
/media/editors/tinymce/plugins/compat3x/mctabs.js', deleted as part of #7667
/media/editors/tinymce/plugins/compat3x/tiny_mce_popup.js', deleted as part of #7667
/media/editors/tinymce/plugins/compat3x/validate.js', deleted as part of #7667
/administrator/components/com_config/controller/application/refreshhelp.php', deleted as part of #8793
/administrator/components/com_media/models/forms/index.html', deleted as part of #8338
/media/com_finder/css/finder-rtl.css', deleted as part of #6322
/media/com_finder/css/selectfilter.css', deleted as part of #6322
/media/com_finder/css/sliderfilter.css', deleted as part of #6322
/media/com_finder/js/sliderfilter.js', deleted as part of #6322
/plugins/editors/tinymce/fields/skins.php', deleted as part of #9796
/plugins/user/profile/fields/dob.php', deleted as part of #9796
/plugins/user/profile/fields/tos.php', deleted as part of #9796
/media/editors/codemirror/mode/kotlin/kotlin.js', delete as of CodeMirror 4.8+
/media/editors/codemirror/mode/kotlin/kotlin.min.js', delete as of CodeMirror 4.8+

// Joomla 3.6.0 FOR DELETE CONSIDERATION
/libraries/joomla/application/web/client.php', deleted as part of #9569

DIRECTORIES
/administrator/components/com_media/models/forms', 3.5.0 deleted as part of #8338
/media/com_banners', 3.4.4
/media/editors/codemirror/mode/kotlin', 3.5.0 delete as of CodeMirror 4.8+
/media/editors/codemirror/mode/smartymixed', 3.4.2
/media/editors/tinymce/plugins/compat3x', 3.5.0 deleted as part of #7667
/plugins/editors/tinymce/fields', 3.5.0 deleted as part of #9796
/plugins/user/profile/fields', 3.5.0 deleted as part of #9796

Great I will turn this into a pull request in the morning

Partial match with #12287

@zero-24 I am not going to have time to do that PR anytime soon

Closed as we have a PR #12378