? Success

User tests: Successful: Unsuccessful:

avatar jeckodevelopment
jeckodevelopment
15 Aug 2016

Pull Request for Issue #11612.

Summary of Changes

This PR increases the size of the link field for the com_newsfeeds from 200 to 2048 in order to handle long URLs for Feeds.

This PR fixes also a mistake in a tip, included in the installation SQL files.

Testing Instructions

Apply the patch and try to store a feed URL longer than 200 characters.

Documentation Changes Required

Not needed.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2016
Category SQL Administration Components Installation Postgresql MS SQL
avatar jeckodevelopment jeckodevelopment - open - 15 Aug 2016
avatar jeckodevelopment jeckodevelopment - change - 15 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Aug 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Aug 2016

you need to make updates for postegresql and sqlazure too

avatar jeckodevelopment
jeckodevelopment - comment - 15 Aug 2016

@andrepereiradasilva can you please check if they are ok?

avatar jeckodevelopment
jeckodevelopment - comment - 15 Aug 2016

@andrepereiradasilva done. Hope that's ok now :)

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Aug 2016

fix in postgresql too please

avatar jeckodevelopment
jeckodevelopment - comment - 15 Aug 2016

@andrepereiradasilva done in PostegreSQL, but I can't find it on SQL Azure.
Can you please check/test?

avatar jeckodevelopment
jeckodevelopment - comment - 15 Aug 2016

@andrepereiradasilva done for MySQL, Azure SQL, PostgreSQL (comment style)

avatar andrepereiradasilva andrepereiradasilva - test_item - 15 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Aug 2016

I have tested this item successfully on df6f2d1

on code review

didn't test the upgrade process


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar jeckodevelopment jeckodevelopment - change - 15 Aug 2016
The description was changed
avatar jeckodevelopment jeckodevelopment - edited - 15 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - test_item - 16 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Aug 2016

I have tested this item successfully on a34afcd

just conflicts fixed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar jeckodevelopment
jeckodevelopment - comment - 16 Aug 2016
avatar jeckodevelopment
jeckodevelopment - comment - 16 Aug 2016

@dkanchev can you please test this patch?

avatar zero-24 zero-24 - test_item - 16 Aug 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Aug 2016

I have tested this item successfully on a34afcd

looks good from here. I have just tryed the mysql part.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar zero-24
zero-24 - comment - 16 Aug 2016

@alikon can you double check the non-mysql parts here?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar alikon
alikon - comment - 16 Aug 2016

postgresql is ok
sqlazure is ok by review

avatar alikon alikon - test_item - 16 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 16 Aug 2016

I have tested this item successfully on a34afcd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar zero-24
zero-24 - comment - 16 Aug 2016

Thanks @alikon

avatar zero-24 zero-24 - change - 16 Aug 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 16 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11614.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-16 20:10:24
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Aug 2016
avatar rdeutz rdeutz - merge - 16 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment