? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Aug 2016

Redo of #11295

9aacf9e 14 Aug 2016 avatar brianteeman email
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Category Repository Administration Components Media Manager Language & Strings Modules Front End
avatar brianteeman brianteeman - open - 14 Aug 2016
avatar brianteeman brianteeman - change - 14 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ? ?
avatar jeckodevelopment jeckodevelopment - test_item - 14 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

I have tested this item successfully on 43d92c5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11604.

avatar infograf768
infograf768 - comment - 14 Aug 2016

I suggest to separate the PRs as this is impossible to test

1 for language strings changes
1 for Comments/Doc blocks
1 for the sample data
1 for the test csv

avatar brianteeman
brianteeman - comment - 14 Aug 2016

4 people managed to review the original pr this is just a redo to avoid merge conflicts

avatar infograf768
infograf768 - comment - 14 Aug 2016

Have anyone really tested all? This is touching a lot of files.

avatar andrepereiradasilva andrepereiradasilva - test_item - 14 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Aug 2016

I have tested this item successfully on 32cbd3a

On code review. Just comments and string changes.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11604.

avatar brianteeman
brianteeman - comment - 14 Aug 2016
avatar brianteeman
brianteeman - comment - 14 Aug 2016

@rdeutz should be ready to merge now

avatar rdeutz rdeutz - change - 14 Aug 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-14 16:49:57
Closed_By rdeutz
avatar brianteeman
brianteeman - comment - 14 Aug 2016

Thanks

Add a Comment

Login with GitHub to post a comment