? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 Aug 2016

Pull Request for Improvement.

Summary of Changes

Replace com_plugins existing 404 JError for a 403 php exception when the user does not have access to "Access Administration Interface" (core.manage).

Also adds a custom exception JControllerExceptionNotallowed for this effect.

Before

image

After

image

Testing Instructions

  1. Use latest staging
  2. Create a user and add it to "Administrator" group
  3. Go to com_plugins and set "Access Administration Interface" (core.manage) to "Denied" for "Administrator" group
  4. Login with the Administrator user in a private window and go to /administrator/index.php?option=com_plugins
  5. See the red message (Before)
  6. Apply patch
  7. Repeat step 4, you'll see now a 403 error (After).

When/If merged i can do it for the other components.

thanks @mbabker

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Category Administration Components Libraries
avatar andrepereiradasilva andrepereiradasilva - open - 14 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 14 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 14 Aug 2016
avatar alikon alikon - test_item - 14 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 14 Aug 2016

I have tested this item successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593.

avatar jeckodevelopment jeckodevelopment - test_item - 14 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

I have tested this item successfully on e1253ed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593.

avatar MATsxm MATsxm - test_item - 14 Aug 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 14 Aug 2016

I have tested this item successfully on e1253ed

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593.

avatar jeckodevelopment jeckodevelopment - change - 14 Aug 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

RTC please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 14 Aug 2016
avatar rdeutz rdeutz - merge - 14 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 14 Aug 2016
avatar rdeutz rdeutz - change - 14 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-14 16:28:49
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment