[#11588] - Proxy JData to the Framework
- Closed
- 4 Sep 2016
- Medium
- Build: staging
- # 11588
- Diff
- mbabker:proxy-JData
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Summary of Changes
The JData classes and the joomla/data Framework package are largely one in the same with the latter having received some new code not existing in the CMS. Since this is basically duplicate code, let's merge sources.
Testing Instructions
If anyone's using these classes (sorry, core doesn't use them), make sure your code still works the same without changes; similar to JRegistry, the existing classes are aliased to their namespaced counterparts. The only gotcha might be if you're using Reflection on the private class member variables, but as those are private anyway there's no room for a B/C break. Otherwise, this is essentially a maintainer review thing.
Documentation Changes Required
N/A, the JData classes are not documented in the CMS workspace
joomla-cms-bot
- | Category | ⇒ | Administration Components External Library Libraries Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 00:08:29 |
| Closed_By | ⇒ | wilsonge |
I'm guessing this needs to be rebased to get the unit test changes, since all of the unit tests are erroring in this PR.