[#11584] - Throw Exceptions in JSessionStorage::getInstance() versus jexit()
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- # 11584
- Diff
- mbabker:Session-Connection-Exceptions
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Instead of exiting the application completely when we are unable to get a session storage object, throw exceptions. The code commented inline the exit was intentional because the processing would try to close a non-existing session, however since there isn't a way with Joomla's API to start a session without a successful return from this instance there wouldn't be a session to close.
Testing Instructions
Set the $session_handler var in your configuration to "xcache" and try to load Joomla. You should get a "Error displaying the error page: Application Instantiation Error: The xcache Session Storage is not supported on this platform." message which means this message was displayed via JErrorPage::render(). There's no change in behavior for functional configurations.
Documentation Changes Required
N/A, there is no extra documentation beyond the API docs for this method.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 13:54:49 |
| Closed_By | ⇒ | wilsonge |
Merged on review
I have tested this item✅ successfully on c1cb668
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11584.