[#11579] - Move travis phpunit test preparations into a bash script
- Closed
- 13 Aug 2016
- Medium
- Build: staging
- # 11579
- Diff
- yvesh:travisgsoc
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for #11420.
Summary of Changes
As asked by @rdeutz in #11420 phpunit tests should not be executed when running the javascript tests. In order to achieve that we need to clean up the .travis.yml and move the tests setup to a separate bash script.
This also has the advantage that the formatting and execution workflow can be improved over the one liners we have because of travis now. (Not done with this PR)
Testing Instructions
Review and check the travis log
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:41:58 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
A little late to the party but can someone move the shell script to the build/travis directory? It's only usable in the Travis environment so it's better to have it there versus in the tests directory. Either that or rename the file to make it perfectly clear it's a Travis environment configuration script.
Makes sense I will make a PR to move the file
I have tested this item✅ successfully on 23e6e6b
Works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.