[#11577] - [installation] Created in 2011-01-01? Update created date plus minor corrections
- Closed
- 8 Nov 2016
- Medium
- Build: staging
- # 11577
- Diff
- andrepereiradasilva:patch-19
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Joomla on install articles, categories etc with a created date with more than 5 years (2011-01-01) which does not look good when you are installing something new.
So this PR adds a method to the installation process to update core and sample data created dates to the current date.
Also corrects category creator id in com_banners and com_user_notes (was missing).
Testing Instructions
- Use latest staging
- Delete configuration.php, refresh the page and install joomla with any sample data install step
- Check the created dates of articles, categories, contacts, etc
- Now apply this patch, delete configuration.php, refresh the page and install joomla
- Repeat step 2 to 3 check the created date is now the Joomla install date.
- Do a code review.
joomla-cms-bot
- | Category | ⇒ | Installation |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
ok i understood
will check that
Thanks - and sorry if I am making work for you but its needed
np. will chek when i have time
ok @brianteeman sample_testing is now excluded. please test.
i've not tested exactly as described
- fresh install with current staging + blog data
- enabled & installed multilanguage (4) content too
it seems ok
but noticed some incongruent date (Modified Date < Created Date)
and for article is more incongruent (Start Publishing < Modified Date < Created Date )
| Category | Installation | ⇒ |
| Category | ⇒ | Installation |
ok, now should update all the dates (except null dates)
please test install with/without sampledata and in mysql and postgresql.
Dates looked ok. Installed with blog data
JUser: :_load: Unable to load user with ID: 713
in com_content the created_by is correct (in my case132) but the modified_by is wrong with 713
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11577.
JUser: :_load: Unable to load user with ID: 713
that as nothing to do with this PR
in com_content the created_by is correct (in my case132) but the modified_by is wrong with 713
that as nothing to do with this PR
| Category | Installation | ⇒ |
| Category | ⇒ | Installation |
Looks good to me now. Can I have one person quickly retest this just to make sure there are no new issues with the rebase? Thanks!
Making a note for myself to test again tonight
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11577.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-08 10:58:28 |
| Closed_By | ⇒ | wilsonge |
| Status | Fixed in Code Base | ⇒ | Pending |
| Milestone |
Added: |
||
Thanks Andre!
I understand what you are doing with this and its a good idea
The only small issue is with the testing data (which is no longer shipped with the cms and is only in the github download) where we do need to keep the existing dates or all the articles get the same date and it will be hard to test ordering etc.
So is it possible to exclude running updateCreatedDates when you have selected that dataset