? ? ? Success

User tests: Successful: Unsuccessful:

avatar designbengel
designbengel
11 Aug 2016

Summary of Changes

Added a show_introtext parameter to the newsflash module

Testing Instructions

Before applying the patch publish a Newsflashmodule
1) After applying the patch look if the introtext is still shown as default
2) Set Introtext to Hide -> Introtext should be hidden
4) Set Introtext to Show -> Introtext should be shown

Documentation Changes Required

image

avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2016
Category Language & Strings Front End Modules
avatar designbengel designbengel - open - 11 Aug 2016
avatar designbengel designbengel - change - 11 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2016
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 11 Aug 2016

please have a look here: designbengel#4 the option needs to be enabled by default for B/C πŸ˜„

avatar designbengel
designbengel - comment - 11 Aug 2016

@zero-24 i enabled it by default ?

avatar designbengel
designbengel - comment - 11 Aug 2016

@jeckodevelopment thatΒ΄s why i copied the text/translation and the parameter name from the mod_articles_category ?
I can change it of course, but should i change it then in mod_articles_category also ?

avatar designbengel
designbengel - comment - 11 Aug 2016

@zero-24 sorry seems i enabled it without comitting :-D (facepalm) ;)

avatar jeckodevelopment
jeckodevelopment - comment - 11 Aug 2016

@designbengel let's wait for @brianteeman 's opinion :)

avatar brianteeman
brianteeman - comment - 12 Aug 2016

Can you change the label to
"Show Intro Text"
and the description to
"Show or hide the article intro text."

I've been trying to standardise on that and have an RTC pull request to fix most of the remaining instances

(note to self to review our usage of "intro text" and "introtext"

avatar 1apweb 1apweb - test_item - 12 Aug 2016 - Tested unsuccessfully
avatar 1apweb
1apweb - comment - 12 Aug 2016

I have tested this item πŸ”΄ unsuccessfully on 59efa71

Hi,
Show: the whole article appears
Hide: the article does not appear


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar zero-24
zero-24 - comment - 12 Aug 2016

@1apweb is that not the expected behavior? What did not work?

avatar 1apweb 1apweb - test_item - 12 Aug 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 12 Aug 2016

I have tested this item βœ… successfully on 59efa71

Sorry, its ok now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar truptikagathara truptikagathara - test_item - 13 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 13 Aug 2016

I have tested this item βœ… successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar designbengel
designbengel - comment - 13 Aug 2016

@1apweb & @truptikagathara thank you for testing

avatar mikeveeckmans mikeveeckmans - test_item - 13 Aug 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 13 Aug 2016

I have tested this item βœ… successfully on 8c0e15a

patch tested and works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar brianteeman brianteeman - change - 13 Aug 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 13 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Aug 2016
Labels Added: ?
avatar yvesh yvesh - test_item - 13 Aug 2016 - Tested successfully
avatar yvesh
yvesh - comment - 13 Aug 2016

I have tested this item βœ… successfully on 8c0e15a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.

avatar designbengel
designbengel - comment - 13 Aug 2016
avatar jeckodevelopment
jeckodevelopment - comment - 13 Aug 2016

you're welcome @designbengel , thank you for your PR :)

avatar wilsonge
wilsonge - comment - 3 Sep 2016

Merged to the 3.7.x branch with 84b6c70. Thanks Elisa!

avatar wilsonge wilsonge - change - 3 Sep 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-09-03 11:30:04
Closed_By wilsonge
avatar brianteeman brianteeman - change - 3 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment