[#11564] - added show/hide introtext parameter to mod_articles_news
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 11564
- Diff
- designbengel:introtext_params_mod_articles_news
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Added a show_introtext parameter to the newsflash module
Testing Instructions
Before applying the patch publish a Newsflashmodule
1) After applying the patch look if the introtext is still shown as default
2) Set Introtext to Hide -> Introtext should be hidden
4) Set Introtext to Show -> Introtext should be shown
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Language & Strings Front End Modules |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
@jeckodevelopment that´s why i copied the text/translation and the parameter name from the mod_articles_category ?
I can change it of course, but should i change it then in mod_articles_category also ?
@zero-24 i enabled it by default ?
https://github.com/joomla/joomla-cms/pull/11564/files#diff-1b513a4609e09b6bd5c4b989a6541998R107
default is = "0"?
@designbengel let's wait for @brianteeman 's opinion :)
Can you change the label to
"Show Intro Text"
and the description to
"Show or hide the article intro text."
I've been trying to standardise on that and have an RTC pull request to fix most of the remaining instances
(note to self to review our usage of "intro text" and "introtext"
I have tested this item
Hi,
Show: the whole article appears
Hide: the article does not appear
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.
I have tested this item
Sorry, its ok now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.
@1apweb & @truptikagathara thank you for testing
I have tested this item
patch tested and works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11564.
Thank you @yvesh @mikeveeckmans @brianteeman @jeckodevelopment @1apweb @truptikagathara @zero-24 - for supporting my first PR ;)
you're welcome @designbengel , thank you for your PR :)
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 11:30:04 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
please have a look here: designbengel#4 the option needs to be enabled by default for B/C?