[#11562] - Use JHtmlBootstrap in front-end editing
- Closed
- 13 Aug 2016
- Medium
- Build: staging
- # 11562
- Diff
- n9iels:jhtml-form
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR replaces the hard coded bootstrap tabs in com_content.form with JHtml::_("bootstrap.tab"). The advantage of this change is that we can override this library to use Bootstrap 3 for example.
Testing Instructions
- Log in on the front-end and edit an article
- Make sure all the tabs are working correctly
- Apply this PR
- Make sure all the tabs are still working correctly
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Could you use a more specific selector other than myTab? I think I've seen this in other places in Joomla so it could cause conflicts
@brianteeman yes i'm sure the were Bootstrap tabs. The code generated by the JHtml library is exactly the same as it was before. So nothing will change after this update.
@C-Lodder Good point, I changed the selector to com-content-form
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11562.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11562.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11562.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11562.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 18:00:03 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Are you sure they were bootstrap tans before? What happens now if you have
a non bootstrap template?