? Pending

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
10 Aug 2016

Make category controller similar to PRs

#11503
#11502
#11511

Testing instructions

Test that edit and edit own in backend category manager work properly

avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2016
Category Administration Components
avatar ggppdk ggppdk - open - 10 Aug 2016
avatar ggppdk ggppdk - change - 10 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2016
Labels Added: ?
avatar ggppdk
ggppdk - comment - 15 Aug 2016

@wilsonge

please do not forget of this one, it is related to the other PRs

avatar ggppdk ggppdk - change - 15 Aug 2016
The description was changed
avatar ggppdk ggppdk - edited - 15 Aug 2016
avatar ggppdk ggppdk - change - 15 Aug 2016
Title
Refactor category controller
Refactor allowEdit of category controller
avatar ggppdk ggppdk - edited - 15 Aug 2016
avatar ggppdk ggppdk - change - 16 Aug 2016
Title
Refactor allowEdit of category controller
Refactor allowEdit of backend category controller
avatar ggppdk ggppdk - edited - 16 Aug 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Aug 2016

ok so i just found on ething that seems an issue, or at leaset and inconsistency

  • use a user with "Administrator" group
  • create with that user this two categories

image

  • Create another category with super user so it stays like this

image

  • At com_content set Edit as Denied for the "Administrator" group
  • At "Test ACL" level don't change permission
  • At "Test ACL Sub" level set "Edit Own to "Denied"
  • At "Test ACL Sub (Super User)" level don't change permission
  • Now use the test user and you will get something like this image

All ok.

  • Now try to access /administrator/index.php?option=com_categories&task=category.edit&id=12&extension=com_content (replace 12 for the id of the "Test ACL Sub (Super User)" category). You get
    image

  • Now try to access /administrator/index.php?option=com_categories&task=category.edit&id=11&extension=com_content (replace 11 for the id of the "Test ACL Sub" category). Here, instead of getting the "Edit not allowed" error (as all the other cases) you go to the "Edit" layout, but without save buttons
    image

This happens with and without your patch.
Can you check if this is the supposed behaviour?

avatar ggppdk
ggppdk - comment - 19 Aug 2016

Good catch, thanks

i replicated it , for an (administrator) user that owns the record (category),
and "edit own" was denied for administrator usergroup

In my local testing copy,
i did not have that check included (so it was working properly in my tests ...),

and when editing the file via Github UI, i failed to remove it from the old code

please retest

avatar andrepereiradasilva andrepereiradasilva - test_item - 19 Aug 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Aug 2016

I have tested this item successfully on 0767861

Seems to work fine now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11547.

avatar dgt41 dgt41 - test_item - 26 Aug 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 26 Aug 2016

I have tested this item successfully on 0767861


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11547.

avatar dgt41 dgt41 - change - 26 Aug 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 26 Aug 2016

RTC

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-26 08:59:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 26 Aug 2016
avatar wilsonge wilsonge - merge - 26 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment