Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11540] - Added Feature items filter to mod_articles_news

? ? Success

User tests: Successful: Unsuccessful:

avatar nickyeoman
nickyeoman
10 Aug 2016

Pull Request for Issue #11539 .

Summary of Changes

The feature item filter was already available for the
mod_articles_latest module, but that is just a list.
All code was slightly modified from the mod_articles_latest module.

Testing Instructions

  • Login to the joomla administrator
  • Add the module Articles - Newsflash
  • You should now see a filter parameter for featured

Documentation Changes Required

https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Articles_Newsflash
Should be updated to include the featured articles filter
Just copy and paste what is here: https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Latest_News

avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2016
Category ⇒ Language & Strings Front End Modules
avatar nickyeoman nickyeoman - open - 10 Aug 2016
avatar nickyeoman nickyeoman - change - 10 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2016
Labels Added: ? ?
avatar Hils
Hils - comment - 10 Aug 2016

Small change: Without the Oxford Comma?
"Select to Show, Hide, or Only display Featured Articles."

avatar brianteeman
brianteeman - comment - 10 Aug 2016

@hils lets leave it in for now so it is identical to the other string and then the "issue" of the Oxford comma can be addressed in a single pull request

avatar hardiktailored hardiktailored - test_item - 11 Aug 2016 - Tested successfully
avatar hardiktailored
hardiktailored - comment - 11 Aug 2016

I have tested this item ✅ successfully on b0e6d3d

Now I can see the 'Featured Articles' parameter selection and all three option works as expected.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540.

avatar 1apweb 1apweb - test_item - 12 Aug 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 12 Aug 2016

I have tested this item ✅ successfully on b0e6d3d

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540.

avatar brianteeman brianteeman - change - 14 Aug 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 14 Aug 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Aug 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 1 Oct 2016

@nickyeoman could you have a look at the conflicts and resolve them, thanks!

avatar zero-24 zero-24 - change - 3 Oct 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 16 Oct 2016

@nickyeoman please see: nickyeoman#1 and merge to fix the conflicts

avatar zero-24 zero-24 - close - 25 Oct 2016
avatar zero-24 zero-24 - change - 25 Oct 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-10-25 10:14:37
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 25 Oct 2016
avatar zero-24
zero-24 - comment - 25 Oct 2016

New PR: #12547

avatar joomla-cms-bot joomla-cms-bot - close - 25 Oct 2016
avatar zero-24 zero-24 - close - 25 Oct 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2016
Labels Removed: ?
avatar zero-24 zero-24 - change - 25 Oct 2016
Labels Removed: ?
avatar zero-24 zero-24 - change - 29 Oct 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment