? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Aug 2016

We do need the id of the menu item in the $this->fields = array( in a menu item edit.php) for the GSOC multilingual project.
It was missing anyway to display the id in the page.

After patch, the readonly field will display:
screen shot 2016-08-09 at 07 59 50

Can be merged on review.
@andrepereiradasilva @alikon @jreys
@wilsonge

avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2016
Category Administration Components
avatar infograf768 infograf768 - open - 9 Aug 2016
avatar infograf768 infograf768 - change - 9 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2016
Labels Added: ?
avatar alikon
alikon - comment - 9 Aug 2016

tested ok
but unable to mark successfull test on issues.joomla.org

avatar infograf768 infograf768 - alter_testresult - 9 Aug 2016 - alikon: Tested successfully
avatar infograf768
infograf768 - comment - 9 Aug 2016

I marked it for you

avatar jreys jreys - test_item - 9 Aug 2016 - Tested successfully
avatar jreys
jreys - comment - 9 Aug 2016

I have tested this item successfully on ab4c091


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525.

avatar infograf768 infograf768 - change - 9 Aug 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 9 Aug 2016

@wilsonge

Thank you for merging


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - test_item - 9 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 9 Aug 2016

I have tested this item successfully on ab4c091


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525.

avatar wilsonge
wilsonge - comment - 9 Aug 2016

What is this needed for? Seems kind of counterintuitive to the UI?

avatar jreys
jreys - comment - 9 Aug 2016

@wilsonge , this is needed in order to save associations on the side-by-side, without jform_id, I can't save new associations since I don't know which ID was generated

avatar alikon alikon - test_item - 9 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 9 Aug 2016

I have tested this item successfully on ab4c091

test to test joomla/jissues#860


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525.

avatar brianteeman
brianteeman - comment - 10 Aug 2016

Does this field need to be displayed in the UI. Doesnt seem any need for it to be displayed to me and just adds meaningless clutter


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525.

avatar infograf768
infograf768 - comment - 11 Aug 2016

It does NOT need to be displayed but it is useful information that can be copied and does not clutter as it is at bottom of all fields.

avatar wilsonge
wilsonge - comment - 12 Aug 2016

OK Can we make this a hidden field on the page - with an ID on the hidden field available for JS access

avatar infograf768
infograf768 - comment - 12 Aug 2016

@wilsonge
Done. imho does not need to be tested again. Can be merged on review.

avatar brianteeman
brianteeman - comment - 12 Aug 2016

Thank you for making that update

avatar wilsonge wilsonge - change - 13 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 18:01:10
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Aug 2016
avatar wilsonge wilsonge - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment