[#11517] - Filter on multiple Access Levels, Authors, Categories, and Tags (continuation)
- Closed
- 28 Aug 2017
- Medium
- Build: staging
- # 11517
- Diff
- florian1995:tags
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #5474 .
I try to finish the great work from @jrseliga.
I fixed the problem that when you deselect for example all tags the list won't refresh. With the example code from @ggppdk it work's like a charm. Thanks for that.
I tested it with MySQL and PostgreSQL and it worked fine. It will be great if someone could test it also with MSSQL.
The following test instructions are also from @jrseliga.
Testing
Administrator
Articles
- Create 3 articles:
- Article 1 - Category 1 - Tag 1 - Author 1 - Public
- Article 2 - Category 2 - Tag 1 & Tag 2 - Author 2 - Registered
- Article 3 - Category 2 - Tag 2 - Author 1 - Super User
- View Articles
- Use Search Tools
Just with a simple structure like this, there is a large number of potential test cases. Please refer to the New behavior section for an overview of the filtering logic
Featured Articles
- View Featured Articles
Use Search Tools
Categories
- View Categories
Use Search Tools
Developed@icampus
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings Front End Modules |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
The labels for the multi-select fields are shown as placeholders
- but when chosen attaches to the multi-select elements, the width of the input element is not calculated correctly, you need to click to open close the chosen element so that it is calculated correctly
To overcome the initial wrong inline CSS:
style="width: 0px;"
this CSS can be used as a workaround
ul.chosen-choices .search-field > input {
width: 100% !important;
}
any better solution ?
I forgot to say that wrong width calculation happens only,
- when the filters slider is closed
if you select any filter
then the slider is open on page load and the labels inside multi-select elements are shown correctly
Thanks for your reply @ggppdk.
If i understand you right the problem is, that sometimes the placeholders are not shown correctly, because the width isnt correct. But i tested it with Chrome and Firefox and dont know how to reproduce the issue, i can select, deselect, open and close the filters how i want, but it never happens. Maybe you can say in detail how to reproduce this issue.
Only thing i can say that the issue occurs (or can occur) when the selects are initially hidden,
because the slider is closed
There is a relevant issue still open in chosen tracker:
harvesthq/chosen#92
- i am using select2 JS for my multi-select filters, and select2 JS in general in all my views, maybe if chosen JS had been updated , i would have been using it,
so i do not know much about it
i think suggested solution was to force it via CSS (see example above)
or add some JS code that .... e.g. will do something on slider open ...
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
@ggppdk do you still have the problem with Joomla 3.7.2. I try to reproduce the problem, but i cant.
Please answer in the next days otherwise we will delete the issue. @nibra
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
I have not tested with j3.7.2 i guess if you tested and it now works , then it has been fixed
I have tested this item
@icampus
I've tested this Issue succesfull. Everything works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
I have tested this item
Operating System
- Joomla! 3.8.0-beta3-dev
- PHP 5.6.2
- MySQLi 5.5.38
- Apache/2.2.29 (Unix)
Steps
- Open article administration
- Use search tools
Test before patch
- Single filter selection
Test after patch
- Multi filter selection for category, access, author tag
Tested @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
| Category | Administration Components Language & Strings Front End Modules | ⇒ | Administration com_categories com_content com_modules com_newsfeeds Language & Strings Front End Modules Components |
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Please resolve conflicting Files.
I have tested this item
tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
@THMmeddah thanks for Test. We need 2 successfully Test for an Pull Request.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11517.
@AresRoxx10 thanks for Test. We need 2 successfully Test for an Pull Request, we have now 4 :-).
@franz-wohlkoenig Issue can be closed as implemented in #17668
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-28 16:06:40 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
Conflicting Files
?
|
||
Closed as requested
Hi @florian1995 i have fixed some Travis issues and a bug see: florian1995#1?