[#11509] - [com_content] Do not generate query twice on featured view and archive view
- Fixed in Code Base
- 7 Sep 2016
- Medium
- Build: staging
- # 11509
- Diff
- csthomas:populateState
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Do not generate sql query twice: on getItems and on getTotal.
Remove $this->setState('list.ordering', ... from getListQuery method and move it to populateState.
Testing Instructions
1) Create a menu item for com_content featured view.
a) Set Category Order: No Order
b) Set Article Order: Author Alphabetical
2) Create a second menu item for com_content archive view
a) Set Article Order as Title Alphabetical
3) Add debug info:
a) at the top of method getListQuery:
https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/featured.php#L121
replace { by:
{echo "<code>getListQuery RUN</code>";b) Do the same for https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/archive.php#L72
4) Go to the first menu item. You should see text "getListQuery RUN" twice.
5) Go to the second menu item. You should see text "getListQuery RUN" twice.
6) Apply this PR and also add debug info at the top of method getListQuery.
7) Go to the first menu item. You should see text "getListQuery RUN" only once.
8) Go to the second menu item. You should see text "getListQuery RUN" only once.
Votes
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.
- I have tested query as per your discussion.
- I have attached two screenshot.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.
@brianteeman Can I ask for RTC / milestone?
don't work for me enabling the debug plugin the number of executed queries are the same with and without the patch (tested only featured)
i'm testing on a clean current stage with multilanguage enabled
1 featured article for 3 languages
I have mentioned only that above queries are only generated, method getListQuery() was run twice but once is enough.
IIRC the details are (before PR):
- getTotal() generate a query in
getListQuery()method, modifies a little, and executes it. - getItems() generate a new query (but should use previous one) and executes it.
sorry for the missunderstanding, consider my previous comment as a successfull non-regression test ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on the recored tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-07 07:45:26 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 115b93b
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11509.