I have tested this item ✅ successfully on 216604b

Agree - on code review

Thanks

I have tested this item ✅ successfully on 216604b

Rtc

@brianteeman imo there is currently no need to update the tests in /tests/system or /tests/codeception as they are never again being used (probably)..

And people are supposed to know that how?

On 7 August 2016 at 19:13, Yves Hoppe notifications@github.com wrote:

@brianteeman https://github.com/brianteeman imo there is currently no
need to update the tests in /tests/system or /tests/codeception as they are
never again being used (probably)..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11505 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8U5VcnECA2zhdWMO5j_CkleyKocPks5qdiBGgaJpZM4Jee7X
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@yvesh if they are not being used they should be removed. If they are being used then they must be kept up to date

@brianteeman yeah, they probably should be removed. They are all outdated anyways and not used anywhere currently (as far as i know)..

if they are not being used then please remove them asap - will save a lot
of work when making pull requests

On 7 August 2016 at 19:53, Yves Hoppe notifications@github.com wrote:

@brianteeman https://github.com/brianteeman yeah, they probably should
be removed. They are all outdated anyways and not used anywhere currently
(as far as i know)..

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11505 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fC7NGrAsgw_qnF5KLGqFmAIhKNkks5qdimbgaJpZM4Jee7X
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Resolved merge conflicts - no need to retest

IMHO, I do not understand this PR. The dropdown displays the Image prefix:

If it was the image name we would also get the suffix (.gif per default) which can be changed by the user via overrides to prefix.png for example.

It is not a prefix

A prefix is an affix https://en.wikipedia.org/wiki/Affix which is
placed before the stem https://en.wikipedia.org/wiki/Word_stem of a word.
[1]
https://en.wikipedia.org/wiki/Prefix#cite_note-FOOTNOTEWilson2011152.E2.80.93153-1
Adding it to the beginning of one word changes it into another word. For
example, when the prefix un- is added to the word happy, it creates the
word unhappy. Particularly in the study of languages, a prefix is also
called apreformative, because it alters the form of the words to which it
is affixed.

On 8 August 2016 at 06:56, infograf768 notifications@github.com wrote:

IMHO, I do not understand this PR. The dropdown displays the Image prefix:

[image: screen shot 2016-08-08 at 07 51 58]
https://cloud.githubusercontent.com/assets/869724/17470533/672cf896-5d3d-11e6-872d-d761e4ea7e1f.png

If it was the image name we would also get the suffix (.gif per default)
which can be changed by the user via overrides to prefix.png for example.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11505 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8duNsXZgxrqW4nz0cP_4lD5MrwCLks5qdsUqgaJpZM4Jee7X
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/