[#11497] - [com_joomlaupdate] Allow a different reinstall URL than the update URL
- Closed
- 19 Nov 2016
- Medium
- Build: staging
- # 11497
- Diff
- zero-24:improveReinstall
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11488
Notice
Don't do that never on your Live Site please install a dev / test install!
Summary of Changes
With this patch applyed you can use a different reinstall URL than the update url.
For Updating you need just the Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip package for reinstall you need the Joomla_3.6.2-Stable-Update_Package.zip.
So now if we have a reinstall URL configured lets use it.
Testing Instructions
Tip: Do not hit the Update or Reinstall button on testing else the applyed PR gets reverted!
- install 3.6.2
- go to com_joomlaupdate
- see the reinstall URL is
Joomla_3.6.2-Stable-Update_Package.zip - apply this patch
- switch the update server to http://www.jah-tz.de/downloads/core/list2.xml
- go to com_joomlaupdate again
- see the reinstall URL is
Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip - switch back to the core Update server
- see that now we have
Joomla_3.6.2-Stable-Update_Package.zipback. - switch the update server to http://www.jah-tz.de/downloads/core/list3.xml
- notice there is a update that points to
Joomla_3.6.2-Stable-Update_Package.zip#### Documentation Changes Required
There is a core used only new entry for the extension.xml used by the core updater.
Additional Information
The Joomla Core Update Server needs to be extended to use the function with this line. if that line is missing reinstallurl is the same as the update url:
<reinstallurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip</reinstallurl>
A complete example:
<?xml version="1.0" ?>
<updates>
<update>
<name>Joomla! 3.6</name>
<description>Joomla! 3.6 CMS</description>
<element>joomla</element>
<type>file</type>
<version>3.6.2</version>
<infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5667-joomla-3-6-2-released.html</infourl>
<downloads>
<downloadurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip</downloadurl>
<reinstallurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.6.2/Joomla_3.6.2-Stable-Update_Package.zip</reinstallurl>
</downloads>
<tags>
<tag>stable</tag>
</tags>
<maintainer>Joomla! PLT</maintainer>
<maintainerurl>https://www.joomla.org</maintainerurl>
<section>STS</section>
<targetplatform name="joomla" version="3.6" />
<php_minimum>5.3.10</php_minimum>
</update>
</updates>
On request by @jeckodevelopment and @wilsonge so there is no need to update with a 10mb package from 3.6.1 to 3.6.2 ;)
@brianteeman it does, but only to test this PR since we cannot use the official release URL to test the PR.
that cannot be in the final version then -
On 7 August 2016 at 14:25, Luca Marzo notifications@github.com wrote:
@brianteeman https://github.com/brianteeman it does, but only to test
this PR since we cannot use the official release URL to test the PR.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11497 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fdKP7MGF6KdwxvqOVFbzuXVpgztks5qddyygaJpZM4JeT8m
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
it should be fixed after tests.
In Joomla 3.6.1 after patch applyed and switch the update server (http://www.jah-tz.de/downloads/core/list2.xml) the com_joomlaupdate show the wrong package URL Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip and not the correct Joomla_3.6.1_to_3.6.2-Stable-Patch_Package.zip
In Joomla 3.6.0 after patch applyed and switch the update server (http://www.jah-tz.de/downloads/core/list2.xml) the com_joomlaupdate show the correct package URL Joomla_3.6.x_to_3.6.2-Stable-Patch_Package.zip
ok, I can test it when implemented
There is no plan to implement that here as this can be done with the current code just with another update definition ;)
| Category | ⇒ | Components Installation |
| Status | New | ⇒ | Pending |
can we have the labels here @joomla-cms-bot ?
joomla-cms-bot
- | Category | Components Installation | ⇒ | Administration Components |
Is there anything missing you need to test this or is there no usecase for that feature?
| Milestone |
Added: |
||
So is there now reason to improve the update prozess? Just because this (or similiar) is not merged we still need to push everytime the stable update package that can break installations because of the timeout problems.
I can explain anything you need this to be tested just give me a line what do you need to be explained ;)
Any news or should this be closed?
I suspect that others like me and we don't understand what it is you are doing here
To use the reinstall feature in the update component, right now it requires that the update server serve the full upgrade package to all sites (the smaller patch packages therefore can't be used). This would apparently allow for the patch packages to be served while using the upgrade packages for reinstall by using a new XML element specific to the update component (so specific it's not even introduced into the core update processor's library).
Honestly, I don't see this being useful before 4.0. It's only going to increase maintenance of the XML manifests (for example 3.6 will still have to have the upgrade packages but 3.7, if merged, would allow the reinstall logic).
Currently we have two key features of the updater. Update joomla and reinstall the core files.
For the update we can use a small package e.g. 3.6.x to 3.6.5 for the reinstall we need the full package With all files. Currently we can only add one download file that is used for both features so any update runs via the full package.
With this patch (or similiar) we can use a different URL for reinstall (the full package) and for update (the smaler package)
Is this clearer now? If not please let me know ;)
Honestly, I don't see this being useful before 4.0
So this can /should be closed?
I'm just one person with an opinion
| Category | Components Administration | ⇒ | Repository Unit Tests Administration com_admin SQL Postgresql MS SQL com_banners com_categories com_config Components |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-19 19:09:53 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-11-19 19:09:53 | ⇒ | |
| Closed_By | zero-24 | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-19 19:09:58 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
Why would we want to do this - what is the use case
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11497.