[#11493] - [com_joomlaupdate] Check for Self-Update Feature
- Fixed in Code Base
- 5 Sep 2016
- Medium
- Build: staging
- # 11493
- Diff
- zero-24:updateMeFirst
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11440
Notice
Don't do that never on your Live Site please install a dev / test install!
Summary of Changes
This PR add the functionality that if a update for the update component is in place it should show the user to first update the com_joomlaupdate component.
With the new code in place we check exiplit on every call to the com_joomlaupdate default view for an update of the update component.
If there is a update we don't allow Live Update but the Upload & Install still works as before!
If we have the last update installed -> everything works as before
Testing Instructions
Ok this comes a bit complicated
- Install 3.6.0 https://github.com/joomla/joomla-cms/releases/3.6.0
- ignore all messages to update etc.
- go to the Backend -> Extensions -> Manage -> Update Sites
- disable the update site for com_joomlaupdate (Joomla! Update Component Update Site)
- install the patched com_joomlaupdate e.g. via install from URL (it cointains this PR and also a new update server!)
- double check there is a new Update server for com_joomlaupdate (!)
- go to com_joomlaupdate
- see the mesage that you can't use the
Live Update - follow the link (
Click here to update the component.) - install the update (it just move the version from 3.6.1 to 3.6.2 to pass the update check)
- install the Joomla Core Update
- confirm all works!
Why and how
Disable the official Update Site
If we not disable that it offers us the current com_joomlaupdate package which not include my changes.
Why a own Update server
Else i can't ship my changes to test this pull requrest as Update of the original com_joomlaupdate ;)
Documentation Changes Required
The Core Update Component now inlcues a function to call for a Self Update
Additional Infos
Please give feedback:
- On language strings
- Do we need both the
error messageand the changed Live Update View? Or should we remove theerror message - On code! It works but maybe it can be improved?! -> Feedback please!
- On everything else you notice we can improve!
Question
What do we with users that are unable to access com_installer but are allowed to update joomla? => Handel that with a language string? Please suggest one!
Great, you have read all and this this line too your are awesome
joomla-cms-bot
- | Category | ⇒ | Administration Components Language & Strings |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Yes in case we broken com_installer and com_joomlaupdate with one update :)
Thanks for the feature! :) I think it is very useful in the future because we can change the update component without the Joomla! updates fails.
When I tested the PR I was not able to update Joomla! to 3.6.2 (I got the message "Download of update package fail"), but I believe that is a problem on my local machine. So it tested the feature successful.
About the feedback you asked, I think it is better to just remove the red error message and just use the message below the "Live update is no available".
A lot of messages can make people without experience in updating Joomla! scary and nervous. Also now I see the error First and not the link to the update.
The simple message that we have to update the Joomla! component first before we can update Joomla is enough :)
Thanks @n9iels
When I tested the PR I was not able to update Joomla! to 3.6.2 (I got the message "Download of update package fail"), but I believe that is a problem on my local machine. So it tested the feature successful.
To be sure. Can you please double check that you are able to update using a not modified version of 3.6.0 -> Update for com_joomlaupdate and than 3.6.2?
I think it is better to just remove the red error message and just use the message below the "Live update is no available".
A lot of messages can make people without experience in updating Joomla! scary and nervous. Also now I see the error First and not the link to the update.
The simple message that we have to update the Joomla! component first before we can update Joomla is enough :)
Agree. Lets hear some more opinions on this. Thanks!
Thanks for double checking that.
will this also be added to https://github.com/joomla/update.joomla.org/blob/master/www/core/extensions/com_joomlaupdate.xml ?
Please explain me what you want to be added there? For this PR there is no need to extend that file.
But yes it is meant to first check that file for an update bevor it allows to update the core if that is what you mean.
Please explain me what you want to be added there? For this PR there is no need to extend that file.
You're updating com_joomlaupdate here, so my question is: after this PR gets merged a new release of com_joomlaupdate will be made right?
after this PR gets merged a new release of com_joomlaupdate will be made right?
Generally that only happens if there's a critical need. There isn't anything happening here that is a critical need.
Generally that only happens if there's a critical need. There isn't anything happening here that is a critical need.
isn't critical to prevent people from update from 3.6.0 to 3.6.2 without com_joomlaupdate updated?
Update: ok sorry of course, people will only have this AFTER updating com_joomlaupdate right dah :)
This isn't adding anything to make that update process easier. All it's doing is adding a self check to tell the component it can't update core without updating the component first, which you won't even see if you're updating the component before updating core on one of the older releases. A separate package isn't going to do anything useful here.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11493.
I would be happy on any tests or feedback
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11493.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-05 19:15:41 |
| Closed_By | ⇒ | rdeutz |
Thanks
| Labels |
Removed:
?
|
||
You are disabling live update but not upload and update - is that correct
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11493.