User tests: Successful: Unsuccessful:
When changing the global configuration the validated data should always be saved in the session and not only in case of an error when saving the global configuration in configuration.php failed.
There is an issue when writing numeric values in exponential representaion into any of the numeric fields of the global configuration (like "1.5e+1" instead of 15). This form is valid and is accepted by modern browsers as the content of numeric fields, but when it comes to saving such values within Joomla the value is changed but this is not immediately visible for the administrator.
Status Quo
Change
Notes
Category | ⇒ | Administration Components |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
@franz-wohlkoenig @zero-24 my patch will work regardless of PR #11322 but the test instructions are no longer valid. I will look for another test case where my patch makes a difference, and as soon as I've found one I'll come back. Hope that's OK.
Category | Administration Components | ⇒ | Administration com_config Components |
@franz-wohlkoenig @zero-24 I just updated the test instructions for this PR, it no longer depends upon PR #11322. I hope you can repeat your tests, this time hopefully successful.
I have tested this item
I have tested this item
Works! Thanks
Even if the exponential representation of a numeric value is somewhat esoteric it is valid and it is accepted by modern browsers if the type of the input field is "number". Due to that the validation method for numeric fields should probably be changed such that it not only accepts such values (which is the case today) but also converts them correctly into a number ("1.5e+1" should be converted into "15", not into "1" as is the case today). But this is beyond the scope of this PR.
Sounds good if you have some time it would be great if we can have the needed code as PR to test!
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
@zero-24 About converting values like "1.5e+1" into a number: this is IMO easy to implement by changing the file libraries/joomla/filter/input.php
and there the implementation of the method clean()
. For the cases "INT" / "INTEGER" and "UINT" the pattern to search for should be replaced with the pattern defined for the "FLOAT" / "DOUBLE" case. Since the match will then be converted into an integer resp. positive integer the result should hold the desired value (so "1.5e+1" would be no longer converted into "1" but instead "15").
If you agree I'd make this a new PR...
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-23 09:10:29 |
Closed_By | ⇒ | rdeutz | |
Labels |
I have tested this item? unsuccessfully on 0d273d2
Part "Status Quo": #11322:
No Matching Results
in PatchtesterAfter applied Patch in
FTP Port
field1.1e+1
is saved and shown inconfiguration.php
. Same after replacing value with21
(saved inglobal configuration
andconfiguration.php
).This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11491.