[#11462] - Email cloaking unit tests
- Fixed in Code Base
- 5 Aug 2016
- Medium
- Build: staging
- # 11462
- Diff
- PhilETaylor:EmailCloakingUnitTests
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
THE TRAVIS BUILD PASSED - WOOT WOOT !!! Even PHP 5.3!!!
Hope these links help to collect a list of scenario to test
https://github.com/joomla/joomla-cms/pull/4182#issuecomment-53395318
https://github.com/joomla/joomla-cms/pull/3735#issue-35215540
Ok I think this can be tested and merged so that @wilsonge or @dgt41 can run with it, Im on holiday next week and this weekend is manic with the kids activities
There is inline documentation to understand the concepts
It doesnt provide full 100% unit coverage, its meant to be an example and framework for someone to run with.
To run just these tests, go to your joomla-cms folder and run
phpunit --testsuite plugins --stop-on-failure
Hope these links help to collect a list of scenario to test //@brianteeman
Thanks - I added them as comments inline
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-05 15:17:41 |
| Closed_By | ⇒ | wilsonge |
As this doesn't affect any production code I'm merging this to run with it over the weekend. Thanks for picking up on that old code Phil!!
No worries - enjoy, like I said its far from a finished work and doesnt really "cover" the class its testing at all, but it shows how you could implemented what you were aiming for in a correct phpunit way with assertions.
Love it!