?
avatar FireFly9
FireFly9
4 Aug 2016

Steps to reproduce the issue

I updated the update component first
Had j3.5.1 installed
Downloaded the full 3.6.1 zipped package
Used Method A - that is, put the j3.6.1 zipped file in the temp folder
Although Joomla Update panel did not show me that 3.6.1 was the one I needed, but instead that 3.6.0 was the update to be installed, I proceeded to 'Update' the full version of 3.6.1 (I assumed) which was now in my temp folder.
Update was successful, but it told me that 3.6.0 was now installed and the system info also stated 3.6.0 (so it didn't install from the temp...right?)
Did a cashe clear and a database fix, but it still said 3.6.0 and told me that 3.6.1 now needed to be installed via the 3.6.0 to 3.6.1 patch.
I went to use method A again so opened Filezilla to put the patch in the temp folder, but the full 3.6.1 zip was still there.

Expected result

I was thinking that I could bypass 3.6.0 and install 3.6.1 directly from the temp folder

Actual result

but the Joomla update did not prompt for 3.6.1, and IF the install did use what was in the temp folder - it wasn't deleted afterwards.

System information (as much as possible)

Windows server. Microsoft-IIS/8.5
PHP 5.6.0
J platform 13.1.0

Additional comments

avatar FireFly9 FireFly9 - open - 4 Aug 2016
avatar FireFly9 FireFly9 - change - 4 Aug 2016
The description was changed
avatar FireFly9 FireFly9 - edited - 4 Aug 2016
avatar FireFly9 FireFly9 - change - 4 Aug 2016
The description was changed
avatar FireFly9 FireFly9 - edited - 4 Aug 2016
avatar ggppdk
ggppdk - comment - 4 Aug 2016

This is deliberate. The system asks you to update to J3.6.0 first intentionally. It is a requirement for proper upgrading

avatar FireFly9
FireFly9 - comment - 4 Aug 2016

OK - but the instructions should tell you that. But no matter.
New question on this.
After I could see that the system then wanted me to update to 3.6.1 via the patch, I deleted the full version of 3.6.1 sitting in the temp folder. (I am assuming that it just wasn't used and the 3.6.0 was installed live - correct?)
Anyway....Using method A again I put the 3.6.0-3.6.1 patch in the temp folder and then did the Joomla Update
The install completed (although I did have to do the db fix as instructed)but the zipped patch did not delete from the temp folder.

I think this is a bug in that it is not being deleted OR it is being bypassed and not used at all.
3.5.0 to 3.5.1 deleted the zip from the temp folder automatically.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11454.

avatar brianteeman
brianteeman - comment - 4 Aug 2016

Why aren't you doing it the easy way

avatar FireFly9
FireFly9 - comment - 4 Aug 2016

Because it USED to be that the files were too large and my system would time out, so I have been using the temp folder. 3.5 and 3.5.1 made this really easy to do because you didn't have to unzip it AND it would also delete the zipped file from the temp folder for you.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11454.

avatar FireFly9
FireFly9 - comment - 4 Aug 2016

As suggested by someone who would know about this...
"When the installer code was moved to the Joomla Update component, did it miss the tmp cleanup functionality?"


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11454.

avatar brianteeman
brianteeman - comment - 4 Aug 2016

If that person would know then they can check the code

On 4 August 2016 at 23:17, FireFly9 notifications@github.com wrote:

As suggested by someone who would know about this...
"When the installer code was moved to the Joomla Update component, did it

miss the tmp cleanup functionality?"

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11454
https://issues.joomla.org/tracker/joomla-cms/11454.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WKFgiIpciaI0HTK7Nmlk8H_TLQBks5qcmT_gaJpZM4JdAi-
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar FireFly9
FireFly9 - comment - 5 Aug 2016

I see that 3.6.2 is released?? I'm wondering if this version can be uploaded directly over 3.5.1??

G


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11454.

avatar PhilETaylor
PhilETaylor - comment - 5 Aug 2016

The Joomla Update Extension provided in Joomla handles the extraction of very very large zip files with no issues at all, it will not time out as it extracts in fragments. It also downloads the zip files in fragments and not in one go

There is no reason to do what you are doing, just go to Extension -> Joomla Update and use the built in Joomla update process to update your site.

Also note PHP 5.6.0 is TWENTY FOUR versions behind the only secure version of PHP in the PHP 5.6 series, that is 5.6.24. You should upgrade your PHP version asap.

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Aug 2016

This PR #11689 would allow to upgrade directly from 3.x to 3.6.3+ directly if tested and merged in time of 3.6.3 release.

Also since this is not a bug, should this be closed?

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Nov 2016

can this be closed?

avatar brianteeman
brianteeman - comment - 3 Nov 2016

only if it cannot be confirmed. if it can be replicated then it needs
resolving

has anyone tried it to see if the zip is removed?

On 3 November 2016 at 22:50, andrepereiradasilva notifications@github.com
wrote:

can this be closed?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Y2jleN-QYREQIS8stMmJKSF4jWmks5q6mVOgaJpZM4JdAi-
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar mbabker
mbabker - comment - 3 Nov 2016

If you updated to 3.6.1 or 3.6.2 without updating the update component then yes it would be expected the ZIP remains because the CSRF check will prevent the update finalization from running (which includes removing the ZIP).

So depending on how you updated, it's expected behavior.

avatar brianteeman brianteeman - close - 3 Nov 2016
avatar brianteeman brianteeman - change - 3 Nov 2016
The description was changed
Status New Expected Behaviour
Closed_Date 0000-00-00 00:00:00 2016-11-03 23:43:09
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 3 Nov 2016

Thanks @mbabker - closing this as the expected behaviour in that one release for unavoidable reasons


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11454.

avatar brianteeman brianteeman - edited - 3 Nov 2016
avatar brianteeman brianteeman - close - 3 Nov 2016

Add a Comment

Login with GitHub to post a comment