Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#11446] - [PostgreSQL] Add group by menu type title to avoid sql error

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
4 Aug 2016

Pull Request for Issue #11445.

Summary of Changes

Adds group by clause so query also works on PostgreSQL.

Testing Instructions

  1. Use 3.6.1 with PostgreSQL
  2. Go to menus lists and you will get the error described in the issue
  3. Apply patch
  4. There should be no error anymore

Didn't test in PostgreSQL because i don't have any installation, just followed the same logic as others.

Test also if all continues to work with MySQL.

Additional comments

If joomla suports other database systems people are needed to test on this database systems.

@minhworks Please confirm this works.

avatar andrepereiradasilva andrepereiradasilva - open - 4 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 Aug 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2016
Category ⇒ Administration Components
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 4 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 Aug 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 4 Aug 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 Aug 2016
The description was changed
avatar brianteeman brianteeman - change - 4 Aug 2016
Category Administration Components ⇒ Administration Components Postgresql
avatar alikon alikon - test_item - 5 Aug 2016 - Tested successfully
avatar alikon
alikon - comment - 5 Aug 2016

I have tested this item ✅ successfully on 452b709

tested on staging with PostgreSql 9.4.5

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11446.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Aug 2016

@brianteeman do you have postgresql ? can you test this so this gets in 3.6.3?

avatar brianteeman
brianteeman - comment - 5 Aug 2016

yes - its on my todo list

avatar brianteeman brianteeman - test_item - 5 Aug 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Aug 2016

I have tested this item ✅ successfully on 452b709

Took me a while to realise the bug is only on multilingual web sites but I can confirm this fix on postgres

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11446.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2016
Category Administration Components Postgresql ⇒ Administration Components
avatar brianteeman brianteeman - change - 5 Aug 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Aug 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11446.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2016
Labels Added: ?
avatar alikon
alikon - comment - 5 Aug 2016

Yes it happens with multilingual on

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11446.

avatar rdeutz rdeutz - close - 13 Aug 2016
avatar rdeutz rdeutz - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar rdeutz rdeutz - change - 13 Aug 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-08-13 17:45:24
Closed_By ⇒ rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment