[#11443] - [mod_logged]: Tag contains duplicated `class` attribute
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11443
- Diff
- brianteeman:11441
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #11441 .
Summary of Changes
Tag must contain a single class attribute: class="hasTooltip btn btn-danger btn-mini"
Tag contains duplicated class attribute: class="hasTooltip" at the start and class="btn btn-danger btn-mini" at the end of list of attributes. This meant the button wasnt not being displayed.
This is the admin module to display a list of logged in users. If you dont have this ADMIN module published then you should publish in the cpanel position
Make sure you have one user logged in at the front end of your site. The module should now show two users as per the screenshot below. Ensure that the tooltip is still working and the button is red.
Before PR
After PR
joomla-cms-bot
- | Category | ⇒ | Administration Modules |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
Test successful.
However after doing so, I notice there is more spacing on the right hand side of the "X" icon than the left. This is cause by the following:
[class^="icon-"], [class*=" icon-"] {
display: inline-block;
width: 14px;
height: 14px;
margin-right: .25em; <<< HERE
line-height: 14px;
}
The right margin shouldn't be there, but this would be a different PR though
Thanks for testing by yes that would have to be a separate PR as that would
touch many more areas
On 4 August 2016 at 15:38, Lodder notifications@github.com wrote:
Test successful.
However after doing so, I notice there is more spacing on the right hand
side of the "X" icon than the left. This is cause by the following:[class^="icon-"], [class*=" icon-"] {
display: inline-block;
width: 14px;
height: 14px;
margin-right: .25em; <<< HERE
line-height: 14px;
}The right margin shouldn't be there, but this would be a different PR
though—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11443 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dqgRygX0zsCD3tDC_PsXul6lwmVks5qcflagaJpZM4JcqOi
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11443.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11443.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit | ||||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11443.
rdeutz
- | Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:44:52 | ||||
| Closed_By | ⇒ | rdeutz | |||||
| Labels |
Removed:
?
|
||
(updated screenshots and description)