[#11436] - modal module style
- Fixed in Code Base
- 13 Aug 2016
- Medium
- Build: staging
- # 11436
- Diff
- brianteeman:modulestyle
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8428 .
Summary of Changes
This simple PR removes the confusing styles input in the insert module modal editor-xtd button that can be found in the toolbar when editing content.
It is given priority by being at the top of the screen and yet it is a very rare use case that you would want to override the style already set in the module.
If absolutely needed a user can still set a style by adding it to the generated syntax in the content item itself
After PR
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
So line 30 to 41:
moduleIns = function(type, name) {
var extraVal ,fieldExtra = jQuery("#extra_class");
window.parent.jInsertEditorText("{loadmodule " + type + "}", "' . $editor . '");
window.parent.jModalClose();
};
modulePosIns = function(position) {
var extraVal ,fieldExtra = jQuery("#extra_class");
window.parent.jInsertEditorText("{loadposition " + position + "}", "' . $editor . '");
window.parent.jModalClose();
};
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11436.
oops also var extraVal ,fieldExtra = jQuery("#extra_class"); is useless in both places
can you do a PR against my branch?
sure: brianteeman#3
Thanks I have merged that change
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11436.
I have tested this item
Hi, May be displaying it in search tools?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11436.
| Status | Pending | ⇒ | Ready to Commit |
RTC thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11436.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-13 17:44:30 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@brianteeman I think that there is some javascript that will be useless now and should be also removed. I like this!?