? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Aug 2016

Pull Request for Issue #10812 .
Go to Users - Manage : See that column is "Enabled"

Click on a user: See the corresponding setting in "Account Details" tab which is called "Block this User"

Summary of Changes

change the label to User Status and update the tooltip and change yes/no to enabled/blocked

This is much more logical and consistent with the list view.

After

screen shot 2016-08-07 at 05 52 43

avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Category Administration Components Language & Strings
avatar brianteeman brianteeman - open - 3 Aug 2016
avatar brianteeman brianteeman - change - 3 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Labels Added: ? ?
avatar Lavsteph Lavsteph - test_item - 4 Aug 2016 - Tested successfully
avatar Lavsteph
Lavsteph - comment - 4 Aug 2016

I have tested this item successfully on b6f430a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar 1apweb 1apweb - test_item - 4 Aug 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 4 Aug 2016

I have tested this item successfully on b6f430a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar jeckodevelopment jeckodevelopment - test_item - 5 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 5 Aug 2016

I have tested this item successfully on b6f430a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar brianteeman
brianteeman - comment - 5 Aug 2016

@C-Lodder any idea on solving the red green problem here


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

@brianteeman You talking about the "tick" icon from JIssues? or the actual PR? lol

avatar brianteeman
brianteeman - comment - 6 Aug 2016

@c-lodder The red/green styling on the buttons needs to be reversed without
changing the values

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

Ok, will have a look when I wake up

avatar brianteeman
brianteeman - comment - 6 Aug 2016

Yes I know but that is the one thing we cannot do as that would block all
existing users and enable all banned users. ;)

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

yeah dont worry, just realised and delete my comment.

avatar brianteeman
brianteeman - comment - 6 Aug 2016

I thought if creating a new style noyes but then it looked like the color
class was set in js based on the value. The one thing we can't change

On 6 Aug 2016 11:14 a.m., "Lodder" notifications@github.com wrote:

yeah dont worry, just realised and delete my comment. Trying to look for a
yesno reference in the entire repo but can only find it in the template CSS
file which only sets some padding an minwidth


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VMtxPxMZ2o7hBjsvqWC9QlRIm7uks5qdF5rgaJpZM4Jb2y5
.

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

@brianteeman ok nothing to do with the btn-group-yesno class.

The only way I can see this being possible is to change the value="" attribute value for both options, but this will then involve other changes

avatar brianteeman
brianteeman - comment - 6 Aug 2016

Ok thanks for looking and confirming. Might have to rethink this change then

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

ok got it working. do you want me to add the JS for the Isis template to pastbin to you can just copy and paste it to your repo, or shall I send a PR to your fork?

avatar brianteeman
brianteeman - comment - 6 Aug 2016

Please

avatar C-Lodder
C-Lodder - comment - 6 Aug 2016
avatar C-Lodder
C-Lodder - comment - 6 Aug 2016

@brianteeman - Did you get time to test and merge?

avatar brianteeman
brianteeman - comment - 6 Aug 2016

Nope. Watching the cricket :)

avatar brianteeman
brianteeman - comment - 7 Aug 2016

@c-lodder perfect thanks

I have added a screenshot to the description


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar brianteeman
brianteeman - comment - 7 Aug 2016

@c-lodder perfect thanks

I have added a screenshot to the description


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar brianteeman brianteeman - change - 7 Aug 2016
The description was changed
Labels
avatar brianteeman brianteeman - change - 7 Aug 2016
Labels
avatar dgt41
dgt41 - comment - 7 Aug 2016

@brianteeman @C-Lodder the same code needs to be in all templates and in installation
PS I mean the js part

avatar brianteeman
brianteeman - comment - 7 Aug 2016

Are you sure its in all of them
I only see the existing code in isis, protostar and beez

On 7 August 2016 at 12:02, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman @C-Lodder
https://github.com/C-Lodder the same code needs to be in all templates
and in installation


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8a2JJUNN801b497SfIfNrFk-y2Xcks5qdbsvgaJpZM4Jb2y5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar C-Lodder
C-Lodder - comment - 7 Aug 2016

Ughr, Beez. Wish this template would just die of old age already!

avatar dgt41
dgt41 - comment - 7 Aug 2016

@C-Lodder not only that one we still got hathor

avatar brianteeman
brianteeman - comment - 7 Aug 2016

Definitely not needed for hathor

On 7 August 2016 at 12:07, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@C-Lodder https://github.com/C-Lodder not only that one


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XDbK0HGH2s9bTQyC0EdILCTjdB0ks5qdbxdgaJpZM4Jb2y5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 7 Aug 2016

Sure, i was just replying to the comment for the outdated templates. Anyways the installation needs to be modified as well here: https://github.com/joomla/joomla-cms/blob/staging/installation/template/index.php#L97-L127

avatar brianteeman
brianteeman - comment - 7 Aug 2016

grrh - inline scripts

On 7 August 2016 at 12:13, Dimitri Grammatikogianni <
notifications@github.com> wrote:

Sure, i was just replying to the comment for the outdated templates.
Anyways the installation needs rot be modified as well here:
https://github.com/joomla/joomla-cms/blob/staging/
installation/template/index.php#L97-L127


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8T3cO4rJILjbgLeiYrs2V9ksslv_ks5qdb3CgaJpZM4Jb2y5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar C-Lodder
C-Lodder - comment - 8 Aug 2016

Oh and "Test successful" :)

good for RTC?

avatar brianteeman
brianteeman - comment - 8 Aug 2016

I can't rtc my own so @zero-24

On 8 Aug 2016 9:10 p.m., "Lodder" notifications@github.com wrote:

Oh and "Test successful" :)

good for RTC?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Q-Xajt5ejKVMN2Un6we8c6AMnrWks5qd407gaJpZM4Jb2y5
.

avatar jeckodevelopment jeckodevelopment - change - 13 Aug 2016
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 13 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 13 Aug 2016

Sorry i did not saw it in my notifications? @brianteeman

avatar rdeutz
rdeutz - comment - 14 Aug 2016

Was tempted to put a 3.6.3 milestone on it, but it is a UI change and not a bug fix so it has to wait till 3.7.0

avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

@rdeutz it's not such a big change... it could be classified as UI improvement.

avatar brianteeman
brianteeman - comment - 14 Aug 2016

It was created to fix a bug report ;)

On 14 August 2016 at 17:07, Luca Marzo notifications@github.com wrote:

@rdeutz https://github.com/rdeutz it's not such a big change... it
could be classified as UI improvement.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Rr9FAQXcrEq93w5nvEGe6jm63JFks5qfz07gaJpZM4Jb2y5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar rdeutz
rdeutz - comment - 14 Aug 2016

there must happen more to change my mind ;-)

avatar jeckodevelopment
jeckodevelopment - comment - 14 Aug 2016

Issue was #10812
;)

avatar brianteeman
brianteeman - comment - 14 Aug 2016

a bribe

On 14 August 2016 at 17:15, Luca Marzo notifications@github.com wrote:

Issue was #10812 #10812
;)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Y8HPeWbIB17iXVLdRepaKWQ03ydks5qfz8EgaJpZM4Jb2y5
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mbabker
mbabker - comment - 14 Aug 2016

there must happen more to change my mind ;-)

Someone send this man a 🍺

avatar wilsonge
wilsonge - comment - 3 Sep 2016

Merged with e3c4fca

avatar wilsonge wilsonge - change - 3 Sep 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-09-03 11:58:10
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 3 Sep 2016

Thanks

avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment