User tests: Successful: Unsuccessful:
Pull Request for Issue #10812 .
Go to Users - Manage : See that column is "Enabled"
Click on a user: See the corresponding setting in "Account Details" tab which is called "Block this User"
change the label to User Status and update the tooltip and change yes/no to enabled/blocked
This is much more logical and consistent with the list view.
Category | ⇒ | Administration Components Language & Strings |
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
I have tested this item
I have tested this item
@C-Lodder any idea on solving the red green problem here
@brianteeman You talking about the "tick" icon from JIssues? or the actual PR? lol
Ok, will have a look when I wake up
Yes I know but that is the one thing we cannot do as that would block all
existing users and enable all banned users. ;)
yeah dont worry, just realised and delete my comment.
I thought if creating a new style noyes but then it looked like the color
class was set in js based on the value. The one thing we can't change
On 6 Aug 2016 11:14 a.m., "Lodder" notifications@github.com wrote:
yeah dont worry, just realised and delete my comment. Trying to look for a
yesno reference in the entire repo but can only find it in the template CSS
file which only sets some padding an minwidth
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8VMtxPxMZ2o7hBjsvqWC9QlRIm7uks5qdF5rgaJpZM4Jb2y5
.
@brianteeman ok nothing to do with the btn-group-yesno
class.
The only way I can see this being possible is to change the value=""
attribute value for both options, but this will then involve other changes
Ok thanks for looking and confirming. Might have to rethink this change then
ok got it working. do you want me to add the JS for the Isis template to pastbin to you can just copy and paste it to your repo, or shall I send a PR to your fork?
Please
@brianteeman - Did you get time to test and merge?
Nope. Watching the cricket :)
@c-lodder perfect thanks
I have added a screenshot to the description
@c-lodder perfect thanks
I have added a screenshot to the description
Labels |
Labels |
@brianteeman @C-Lodder the same code needs to be in all templates and in installation
PS I mean the js part
Are you sure its in all of them
I only see the existing code in isis, protostar and beez
On 7 August 2016 at 12:02, Dimitri Grammatikogianni <
notifications@github.com> wrote:
@brianteeman https://github.com/brianteeman @C-Lodder
https://github.com/C-Lodder the same code needs to be in all templates
and in installation—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8a2JJUNN801b497SfIfNrFk-y2Xcks5qdbsvgaJpZM4Jb2y5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Ughr, Beez. Wish this template would just die of old age already!
Definitely not needed for hathor
On 7 August 2016 at 12:07, Dimitri Grammatikogianni <
notifications@github.com> wrote:
@C-Lodder https://github.com/C-Lodder not only that one
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XDbK0HGH2s9bTQyC0EdILCTjdB0ks5qdbxdgaJpZM4Jb2y5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Sure, i was just replying to the comment for the outdated templates. Anyways the installation needs to be modified as well here: https://github.com/joomla/joomla-cms/blob/staging/installation/template/index.php#L97-L127
grrh - inline scripts
On 7 August 2016 at 12:13, Dimitri Grammatikogianni <
notifications@github.com> wrote:
Sure, i was just replying to the comment for the outdated templates.
Anyways the installation needs rot be modified as well here:
https://github.com/joomla/joomla-cms/blob/staging/
installation/template/index.php#L97-L127—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8T3cO4rJILjbgLeiYrs2V9ksslv_ks5qdb3CgaJpZM4Jb2y5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Oh and "Test successful" :)
good for RTC?
I can't rtc my own so @zero-24
On 8 Aug 2016 9:10 p.m., "Lodder" notifications@github.com wrote:
Oh and "Test successful" :)
good for RTC?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Q-Xajt5ejKVMN2Un6we8c6AMnrWks5qd407gaJpZM4Jb2y5
.
Status | Pending | ⇒ | Ready to Commit |
Labels |
Labels |
Added:
?
|
Sorry i did not saw it in my notifications? @brianteeman
Was tempted to put a 3.6.3 milestone on it, but it is a UI change and not a bug fix so it has to wait till 3.7.0
It was created to fix a bug report ;)
On 14 August 2016 at 17:07, Luca Marzo notifications@github.com wrote:
@rdeutz https://github.com/rdeutz it's not such a big change... it
could be classified as UI improvement.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Rr9FAQXcrEq93w5nvEGe6jm63JFks5qfz07gaJpZM4Jb2y5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
there must happen more to change my mind ;-)
a bribe
On 14 August 2016 at 17:15, Luca Marzo notifications@github.com wrote:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11421 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Y8HPeWbIB17iXVLdRepaKWQ03ydks5qfz8EgaJpZM4Jb2y5
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
there must happen more to change my mind ;-)
Someone send this man a
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 11:58:10 |
Closed_By | ⇒ | wilsonge |
Thanks
Labels |
Removed:
?
|
I have tested this item✅ successfully on b6f430a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11421.