[#11414] - News feed relative images
- Closed
- 9 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 11414
- Diff
- brianteeman:newsfeedimages
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #7805 .
Summary of Changes
Displaying RSS feeds using com_newsfeed, many providers mistakenly use relative addressing to display images which results in feed display which includes numerous broken image links.
This code is provided by @monkeytrainer12
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Components |
| Labels |
Added:
?
|
||
Can't we forbid to use relative paths and force to use absolute path only?
No because the newsfeed is NOT from our web site so we cant force anything
@brianteeman Yes, but can we append http:// or https:// in src path when not starting with one of them like replacing src="/" with src="http://"?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11414.
Currently, News Feed is not loading any images. I am testing on 3.6.2.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11414.
@hardiktailored what newsfeed are you trying
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11414.
| Easy | No | ⇒ | Yes |
| Labels |
Removed:
?
|
||
| Category | Front End Components | ⇒ | com_newsfeeds Components Front End |
So long and farewell
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 15:14:12 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
I checked the code, I can see slash removed when URL starting like this src="/", but I think you have not included match for URL like src="../".
Can't we forbid to use relative paths and force to use absolute path only?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11414.