? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Aug 2016

Pull Request for Issue #7669.

Summary of Changes

When we have the title of an article then the itemprop should be headline not name

avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Category Front End Components
avatar brianteeman brianteeman - open - 3 Aug 2016
avatar brianteeman brianteeman - change - 3 Aug 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Labels Added: ?
avatar jeckodevelopment jeckodevelopment - test_item - 4 Aug 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 4 Aug 2016

I have tested this item successfully on 3e3b23f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11410.

avatar hardiktailored hardiktailored - test_item - 5 Aug 2016 - Tested unsuccessfully
avatar hardiktailored
hardiktailored - comment - 5 Aug 2016

I have tested this item ? unsuccessfully on 3e3b23f

itemprop="name" replace with itemprop="headline" in single article, featured articles and archived articles but not changed in category blog article listing, this is still same as before(itemprop="name").


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11410.

avatar brianteeman
brianteeman - comment - 5 Aug 2016

It was deliberately not changed there as it is my opinion that on those
pages it is not the headline of the page as there are multiple titles

On 5 August 2016 at 08:30, Hardiksinh Gohil @ Tailored <
notifications@github.com> wrote:

I have tested this item ? unsuccessfully on 3e3b23f
3e3b23f

itemprop="name" replace with itemprop="headline" in single article,
featured articles and archived articles but not changed in category blog

article listing, this is still same as before(itemprop="name").

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/11410
https://issues.joomla.org/tracker/joomla-cms/11410.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11410 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Utv5FiT0xJsaVzR_og5VuiV7pPsks5qcuaogaJpZM4JbfEm
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar hardiktailored hardiktailored - test_item - 5 Aug 2016 - Tested successfully
avatar hardiktailored
hardiktailored - comment - 5 Aug 2016

I have tested this item successfully on 3e3b23f

@brianteeman Okay, marked successful as other works perfectly.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11410.

avatar brianteeman brianteeman - change - 5 Aug 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Aug 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11410.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2016
Labels Added: ?
avatar truptikagathara truptikagathara - test_item - 5 Aug 2016 - Tested successfully
avatar truptikagathara
truptikagathara - comment - 5 Aug 2016

I have tested this item successfully on 3e3b23f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11410.

avatar rdeutz rdeutz - change - 13 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-13 17:49:47
Closed_By rdeutz
avatar rdeutz rdeutz - close - 13 Aug 2016
avatar rdeutz rdeutz - merge - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment