?
avatar brianteeman
brianteeman
1 Aug 2016

As far as I can tell the Target Position option in mod_menu is redundant and can be removed (at least I couldnt see anywhere it is used or work out how to use it)

It is described in the 2.5 documentation (https://docs.joomla.org/Help25:Extensions_Module_Manager_Menu) but there is no mention of it in the 3.6 documentation https://docs.joomla.org/Help36:Extensions_Module_Manager_Menu

7obd

avatar brianteeman brianteeman - open - 1 Aug 2016
avatar bertmert
bertmert - comment - 1 Aug 2016

One of the never used "special" features "for somebody" I think.

It's used here (window_open):
https://github.com/joomla/joomla-cms/blob/staging/modules/mod_menu/tmpl/default_url.php#L47

If you select Target Window > New Without Navigation in a menu item of type External URL you can add additional key value pairs for the popup window.

If it will not be removed it's not logical that it's only used in External URL.

MOD_MENU_FIELD_TARGET_DESC="JavaScript values to position a popup window, eg top=50,left=50,width=200,height=300."

Description is somehow misleading.

Example with top=0,right=0,width=50,height=50 and google.com:

01-08-_2016_12-43-27

I think it should be removed because one can use tmpl-overrides.

avatar brianteeman
brianteeman - comment - 1 Aug 2016

I tried that before posting and it didn't work for me. I will test again

avatar brianteeman
brianteeman - comment - 1 Aug 2016

OK I can confirm thats how it works now. Sadly we wouldnt be able to remove it as it would be a b/c break


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11380.

avatar brianteeman brianteeman - close - 1 Aug 2016
avatar brianteeman brianteeman - change - 1 Aug 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-08-01 12:04:43
Closed_By brianteeman
avatar brianteeman brianteeman - close - 1 Aug 2016
avatar brianteeman brianteeman - change - 2 Aug 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment