Success

User tests: Successful: Unsuccessful:

avatar anibalsanchez
anibalsanchez
12 May 2013

The pull request includes library files, manifest, modified mysql and postgresql (not sqlazure) files to install Joomla and FoF as a pre-installed library.

The final installation has no difference with a Joomla + FoF installation.

PD: I'm assuming the FoF files are not going to be modified to avoid any conflict with the regular FoF distribution.

Regards,
Anibal

avatar anibalsanchez anibalsanchez - open - 12 May 2013
avatar anibalsanchez
anibalsanchez - comment - 12 May 2013

Hi,

I've tested it only in mysql.

Regards,
Anibal

avatar AmyStephen
AmyStephen - comment - 13 May 2013

Thank you, Anibal.

PD: I'm assuming the FoF files are not going to be modified to avoid any conflict with the regular FoF distribution.

I like you so much I want to agree with all of your comments. =)

That's not even possible, though. First, the class names will have to have a J name. Second, we have to identify what has been forked and how did it change. The goal will be to get rid of as much as possible to use the core classes without impacting functionality.

Now, if that has implications, we'll need to work that out.

Thank you, again!

avatar phproberto
phproberto - comment - 13 May 2013

I think we should close this PR.

What @AmyStephen asked was a repo to see FoF & Joomla! together. That can be shown in @anibalsanchez's repo :

https://github.com/anibalsanchez/Joomla-FoF

The RAD/SDK/Clint version integrated into Joomla! is still being debated.

avatar elinw
elinw - comment - 13 May 2013

This is proposed as a third party library like Simple Pie? In that case no changes to code will ever be made except the headers and no bug fixes or updates would be done except updates of the library as a whole at the total discretion of JBS. .

avatar anibalsanchez
anibalsanchez - comment - 13 May 2013

Hi Amy, The idea behind this PR is to reproduce the same case as FoF installed as first user extension ID 10000. We could give it ID 701.... I think with no impact.... But it's not going to be the same case.

Hi Elin, the FoF files are the same distributed in the upstream version.

Regards,

avatar AmyStephen
AmyStephen - comment - 13 May 2013

@anibalsanchez - talked in the Skype chat and Nic wants to make a few more changes before we get the copy for Joomla. For now, we'll share a link to your repo for those who want a full copy - or the extension link - for those who want to install it. Go ahead and close this one. Thanks very much for getting it updated so folks can see it. =)

avatar anibalsanchez
anibalsanchez - comment - 13 May 2013

Okidoki

avatar anibalsanchez anibalsanchez - close - 13 May 2013
avatar mbabker
mbabker - comment - 13 May 2013

Just for reference, we've purposely set up the #__extensions table so that when new extensions are added to the core distro, they get grouped in with their like extensions in the earlier ranges, hence the reason that user installed extensions start at 10000. So, for libraries, it would be in the 100-199 range, specifically ID 104 since that's the next unused number. The extension ID makes no difference when it comes to updates, whether it's 15 or 10189, the extension can be updated.

avatar anibalsanchez
anibalsanchez - comment - 13 May 2013

Cool, good to know it!!

Add a Comment

Login with GitHub to post a comment