[#11375] - Allow the vote plugin's position to be configured
- Closed
- 4 Sep 2016
- Medium
- Build: 3.7.x
- # 11375
- Diff
- mbabker:vote-position
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Presently the voting plugin only triggers for the onContentBeforeDisplay event. This PR adds the onContentAfterDisplay event as well and makes the position configurable.
Testing Instructions
Apply this patch from a checkout of the 3.7.x branch and ensure the new configuration works correctly.
joomla-cms-bot
- | Category | ⇒ | Language & Strings Administration Plugins Front End |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
|
||
Because the layout PR I did was merged to 3.7 so it wouldn't be very efficient to push this against staging then have to rebase it for 3.7 after it was tested against a completely different code structure.
Ok thanks. Makes sense.
I have tested this item
Enabled votes for articles and displayed reviews, added ratings, showed on top and bottom position from plugin option, etc.
Tested both the events(onContentBeforeDisplay and onContentAfterDisplay) using echo out in code and everything works as expected.
Tested on 3.7.x(https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
@mbabker can you look at the travis issues please and then this can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
The Travis issues exist in the 3.7.x branch and aren't related to this pull request. https://travis-ci.org/joomla/joomla-cms/builds/148585025 is the last Travis build for the branch.
| Status | Pending | ⇒ | Ready to Commit |
Thank @mbabker
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
| Labels |
Added:
?
|
||
Still planned for J 3.7?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
@JoshuaLewis yes
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 13:37:08 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Was there a specific reason this is against 3.7 and not staging? From experience it makes it harder for people to test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.