User tests: Successful: 3 1apweb, bertmert, hardiktailored Unsuccessful: 0
Presently the voting plugin only triggers for the onContentBeforeDisplay
event. This PR adds the onContentAfterDisplay
event as well and makes the position configurable.
Apply this patch from a checkout of the 3.7.x
branch and ensure the new configuration works correctly.
Category | ⇒ | Language & Strings Administration Plugins Front End |
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Labels |
Added:
?
?
|
Because the layout PR I did was merged to 3.7 so it wouldn't be very efficient to push this against staging then have to rebase it for 3.7 after it was tested against a completely different code structure.
Ok thanks. Makes sense.
I have tested this item
Enabled votes for articles and displayed reviews, added ratings, showed on top and bottom position from plugin option, etc.
Tested both the events(onContentBeforeDisplay and onContentAfterDisplay) using echo out in code and everything works as expected.
Tested on 3.7.x(https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
I have tested this item
I have tested this item
@mbabker can you look at the travis issues please and then this can be merged
The Travis issues exist in the 3.7.x branch and aren't related to this pull request. https://travis-ci.org/joomla/joomla-cms/builds/148585025 is the last Travis build for the branch.
Status | Pending | ⇒ | Ready to Commit |
Thank @mbabker
RTC
Labels |
Added:
?
|
Still planned for J 3.7?
@JoshuaLewis yes
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-04 13:37:08 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
Was there a specific reason this is against 3.7 and not staging? From experience it makes it harder for people to test
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11375.